Differential D304

INP-1700 - Translate invalid username phrase
ClosedPublic
Actions

Authored by alex on May 2 2017, 4:48 AM.

Details

Reviewers

erik

Commits

rINP16584: Fixes INP-1700 - Translate invalid username phrase

Test Plan

perform upgrade/install to get new phrases added
login to Admin Console
go to User Management → Users section
open new record adding window
enter @ in Username field
press Save button on toolbar
confirm, that error message for Username field is translated

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not fixing array formatting errors.

Severity	Location	Code	Message
Error	core/units/users/users_config.php:344	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/users/users_config.php:344	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Warning	core/units/users/users_config.php:345	PHPCS.W.CodingStandard.Array.Array.NoLastComma	CodingStandard.Array.Array.NoLastComma

Unit

No Unit Test Coverage

Build Status

Buildable 725
Build 725: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 739.May 2 2017, 4:48 AM

alex retitled this revision from to INP-1700 - Translate invalid username phrase.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1700.

Herald added a reviewer: erik. · View Herald TranscriptMay 2 2017, 4:48 AM

erik accepted this revision.May 2 2017, 5:10 AM

erik edited edge metadata.

This revision is now accepted and ready to land.May 2 2017, 5:10 AM

Closed by commit rINP16584: Fixes INP-1700 - Translate invalid username phrase (authored by alex). · Explain WhyJul 18 2017, 6:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	739	16543		May 2 2017, 4:48 AM	★	★
Diff 2	791	16583	rINP16584	Jul 18 2017, 6:36 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 739

View Options

core/install/english.lang