Unexpected output: Affected paths: relative - resubmit patch.
⚙ D308 INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI
Page MenuHomeIn-Portal Phabricator
Differential D308

INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI
ClosedPublic
Actions

Authored by alex on May 17 2017, 5:31 AM.

Details

Reviewers
erik
Commits
rINP16587: Fixes INP-1705 - Make "Session::NeedQueryString" method always return "false"…
Test Plan
  • run tests from D307
  • in IDE:
    1. open /tools/cron.php for editing
    2. add die($application->HREF('platform/sitemap') . PHP_EOL); line after $application->Init(); line
    3. save changes
  • in CLI:
    1. run php tools/cron.php command
    2. confirm, that link url is displayed and it doesn't contain ?sid=... part

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 731
Build 731: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 745.May 17 2017, 5:31 AM
alex retitled this revision from to INP-1705 - Make "Session::NeedQueryString" method always return "false" when in CLI.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1705.
alex edited edge metadata.May 17 2017, 5:43 AM
alex added a project: Restricted Project.
erik accepted this revision.May 17 2017, 5:50 AM
erik edited edge metadata.
This revision is now accepted and ready to land.May 17 2017, 5:50 AM
alex requested a review of this revision.May 17 2017, 6:13 AM
alex edited edge metadata.

Please test again, because last time you've forgot to test all (skipped 1st line of test plan).

erik accepted this revision.May 17 2017, 9:54 AM
erik edited edge metadata.

Tested also by D307 plan.

This revision is now accepted and ready to land.May 17 2017, 9:54 AM
Closed by commit rINP16587: Fixes INP-1705 - Make "Session::NeedQueryString" method always return "false"… (authored by alex). · Explain WhyJul 18 2017, 6:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 174516543May 17 2017, 5:31 AM
★
★
Diff 279416586rINP16587Jul 18 2017, 6:46 AM
★
★

Diff 745

View Options

core/kernel/session/session.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server