Added line breaks to join expressions.
Details
Details
Add code:
$grids = $this->Application->getUnitOption($event->Prefix, 'Grids');
$grids['ReviewsSection']['Fields']['CatalogItemName'] = array('filter_block' => 'grid_like_filter');
$this->Application->setUnitOption($event->Prefix, 'Grids', $grids);to ReviewsEventHandler::OnAfterConfigRead, after this line:
$this->Application->setUnitOption($event->Prefix, 'CalculatedFields', $calculated_fields);
- go to Website & Content → Comments
- filter grid by just added CatalogItemName column
- confirm, that no SQL error happened
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: Full file re-formatting is not part of this task. Severity Location Code Message Error core/units/reviews/reviews_event_handler.php:638 PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace Error core/units/reviews/reviews_event_handler.php:638 PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact Generic.WhiteSpace.ScopeIndent.IncorrectExact - Unit
No Unit Test Coverage - Build Status
Buildable 818 Build 818: arc lint + arc unit