"Modified" and "ModifiedById" fields connected to category item units.
Details
Details
- Reviewers
alex - Commits
- rINP16674: Fixes INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
rMINC16676: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
rMINB16675: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
rMINN16678: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
rMINL16677: Bug INP-1745 - Connect "Modified" and "ModifiedById" fields to Links
Topics
- create new user in the adm.console
- login with newly created user to front-end
- click on the "Forums" link in the top menu
- click on the "New Topic" link in the sidebar's "Action Box" section
- fill all required fields
- submit form (click "Create" button)
- go to adm console
- click on the "Topics" section
- confirm that just entered topic is visible in the grid, including "Modified On" and "Modified By" columns
- double click just entered topic in the grid to edit it
- confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
- confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field
Links
- click on the "Links" section
- click on the "New Link" button in the toolbar
- fill all required fields
- confirm, that Modified and Modified By fields aren't shown on the form
- submit form (click "Save" button)
- confirm that just entered link is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
- double click just entered link in the grid to edit it
- change some link field value
- submit form (click "Save" button)
- confirm that just modified link have non-empty values in the "Modified On" and "Modified By" columns
- double click just entered link in the grid to edit it
- confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
- confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field
Products
- click on the "Products" section
- click on the "New Product" button in the toolbar
- fill all required fields
- confirm, that Modified and Modified By fields aren't shown on the form
- submit form (click "Save" button)
- confirm that just entered product is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
- double click just entered product in the grid to edit it
- change some product field value
- submit form (click "Save" button)
- confirm that just modified product have non-empty values in the "Modified On" and "Modified By" columns
- double click just entered product in the grid to edit it
- confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
- confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field
Articles
- click on the "Articles" section
- click on the "New Article" button in the toolbar
- fill all required fields
- confirm, that Modified and Modified By fields aren't shown on the form
- submit form (click "Save" button)
- confirm that just entered article is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
- double click just entered article in the grid to edit it
- change some article field value
- submit form (click "Save" button)
- confirm that just modified article have non-empty values in the "Modified On" and "Modified By" columns
- double click just entered article in the grid to edit it
- confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
- confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: Full files re-formatting is not part of this task. Severity Location Code Message Error modules/in-bulletin/units/topics/topics_config.php:312 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:312 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:339 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:339 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:339 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:339 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:341 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:341 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:341 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:341 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:358 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:358 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:358 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:358 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:360 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:360 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter Error modules/in-bulletin/units/topics/topics_config.php:360 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:360 PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore Error modules/in-bulletin/units/topics/topics_config.php:478 PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword CodingStandard.Array.Array.SpaceAfterKeyword Error modules/in-bulletin/units/topics/topics_config.php:478 PHPCS.E.Generic.PHP.LowerCaseKeyword.Found Generic.PHP.LowerCaseKeyword.Found Error modules/in-bulletin/units/topics/topics_config.php:480 PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword CodingStandard.Array.Array.SpaceAfterKeyword Error modules/in-bulletin/units/topics/topics_config.php:480 PHPCS.E.Generic.PHP.LowerCaseKeyword.Found Generic.PHP.LowerCaseKeyword.Found Error modules/in-bulletin/units/topics/topics_config.php:546 PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword CodingStandard.Array.Array.SpaceAfterKeyword Error modules/in-bulletin/units/topics/topics_config.php:546 PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.After CodingStandard.WhiteSpace.CommaSpacing.After Error modules/in-bulletin/units/topics/topics_config.php:546 PHPCS.E.Generic.PHP.LowerCaseKeyword.Found Generic.PHP.LowerCaseKeyword.Found - Unit
No Unit Test Coverage - Build Status
Buildable 878 Build 878: arc lint + arc unit
Event Timeline
Comment Actions
Please also separate test plan into smaller fragments to ease testing. One test plan per each In-Portal module would be great.
modules/in-bulletin/admin_templates/topics/topics_edit.tpl | ||
---|---|---|
81–86 |
there is no point in allowing user to enter Modified field value, because it will be replaced by changed code |
modules/in-bulletin/admin_templates/topics/topics_edit.tpl | ||
---|---|---|
84 | NOTE: Repeat with similar fields in other affected units (covered by this Differential Revision only).
<inp2:m_RenderElement name="inp_label" prefix="bb" field="ModifiedBy"/>
I have Front-End user with both Username and Email fields entered. In grid I'm seeing value of Username field (correct), but during editing I'm setting value of Email field. |