Unexpected output: Affected paths: relative - resubmit patch.
⚙ D378 INP-1780 - Sync "Semaphores" table structure between clean install and upgrade
Page MenuHomeIn-Portal Phabricator
Differential D378

INP-1780 - Sync "Semaphores" table structure between clean install and upgrade
ClosedPublic
Actions

Authored by alex on Jan 27 2020, 6:52 AM.

Details

Reviewers
erik
Commits
rINP16645: Fixes INP-1780 - Sync "Semaphores" table structure between clean install and…
Test Plan
  1. in IDE
    1. enable listening for incoming debug connections (if not enabled already)
    2. open "core/kernel/utility/temp_handler.php" for editing
    3. put a breakpoint on $ids = $this->DoCopyTempToOriginal($this->Tables, null, $master_ids); line in "\kTempTablesHandler::SaveEdit" method
  2. open regular browser window
    1. login to Admin Console
    2. go to Website & Content → Labels & Phrases section
    3. open 2 phrases for editing (remember the IDs, e.g. 15 and 36)
    4. enable debugging (the bug icon in the toolbar)
    5. press "Save" button
    6. continue to next test plan item only, when debugger has stopped at above created breakpoint
  3. in the database
    1. open "Semaphores" table
    2. locate entry matching session id from regular browser window
    3. remember which ID is written after comma in "MainIDs" column
  4. open private browser window
    1. login to Admin Console
    2. go to Website & Content → Labels & Phrases section
    3. open 1 phrase for editing (with ID remembered before)
    4. press "Save" button
    5. confirm, that after ~30 seconds of waiting instead of saving you'll get popup about concurrent Save attempt

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 949
Build 949: arc lint + arc unit

Event Timeline

alex created this revision.Jan 27 2020, 6:52 AM
alex requested review of this revision.Jan 27 2020, 6:52 AM
alex edited the test plan for this revision. (Show Details)Jan 27 2020, 6:52 AM
alex added a project: Restricted Project.
erik accepted this revision.Mar 9 2020, 5:30 AM

Got JS alert "Copying operation in Temporary tables has failed. Please contact website administrator." If this is popup about concurrent Save attempt - then accepted.

This revision is now accepted and ready to land.Mar 9 2020, 5:30 AM
Closed by commit rINP16645: Fixes INP-1780 - Sync "Semaphores" table structure between clean install and… (authored by alex, committed by ). · Explain WhyDec 11 2020, 3:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 192616637Jan 27 2020, 6:52 AM
★
★
Diff 294916644rINP16645Dec 11 2020, 3:46 AM
★
★

Diff 926

View Options

core/install/upgrades.sql

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server