Unexpected output: Affected paths: relative - resubmit patch.
⚙ D45 INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter
Page MenuHomeIn-Portal Phabricator
Differential D45

INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter
ClosedPublic
Actions

Authored by glebs on Mar 3 2015, 3:11 AM.

Details

Reviewers
alex
Commits
rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's…
Test Plan

Requires In-Commerce module installed to test.

  1. enable debug mode
  2. In gc unit (file: modules/in-commerce/units/gift_certificates/gift_certificates_config.php) add 'show_mode' => smDEBUG to section's in-commerce:gift-certificates definition
  3. in the Tools → System Tools section reset Admin Console Sections
  4. go to E-commerce → Discounts & Certificates section and confirm that Gift Certificates tab is visible
  5. disable debug mode
  6. go to E-commerce → Discounts & Certificates section and confirm that Gift Certificates tab is not visible

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1108
Build 1108: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 113.Mar 3 2015, 3:11 AM
glebs retitled this revision from to INP-1410 - show_mode section parameter doesn't affect tabs.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1410.
alex edited the test plan for this revision. (Show Details)Mar 3 2015, 3:17 AM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)
alex added a project: Restricted Project.Mar 27 2016, 6:00 AM
alex retitled this revision from INP-1410 - show_mode section parameter doesn't affect tabs to INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
alex edited the test plan for this revision. (Show Details)Jul 29 2022, 1:45 AM
alex updated this revision to Diff 1076.Jul 29 2022, 1:45 AM

Rebase

alex updated this revision to Diff 1077.Jul 29 2022, 1:46 AM

Remove file, added during testing

alex accepted this revision.Jul 29 2022, 1:46 AM
This revision is now accepted and ready to land.Jul 29 2022, 1:46 AM
Closed by commit rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's… (authored by alex, committed by ). · Explain WhyNov 9 2022, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 111316128Mar 3 2015, 3:11 AM
★
★
Diff 2107616722RebaseJul 29 2022, 1:45 AM
★
★
Diff 3107716722Remove file, added during testingJul 29 2022, 1:46 AM
★
★
Diff 4111616744rINP16745Nov 9 2022, 9:28 AM
★
★

Diff 1076

View Options

core/units/admin/admin_tag_processor.php

Loading...
View Options

modules/in-commerce/units/gift_certificates/gift_certificates_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server