Differential D45

INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter
ClosedPublic
Actions

Authored by glebs on Mar 3 2015, 3:11 AM.

Details

Reviewers

alex

Commits

rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's…

Test Plan

Requires In-Commerce module installed to test.

enable debug mode
In gc unit (file: modules/in-commerce/units/gift_certificates/gift_certificates_config.php) add 'show_mode' => smDEBUG to section's in-commerce:gift-certificates definition
in the Tools → System Tools section reset Admin Console Sections
go to E-commerce → Discounts & Certificates section and confirm that Gift Certificates tab is visible
disable debug mode
go to E-commerce → Discounts & Certificates section and confirm that Gift Certificates tab is not visible

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1109
Build 1109: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 113.Mar 3 2015, 3:11 AM

glebs retitled this revision from to INP-1410 - show_mode section parameter doesn't affect tabs.

glebs updated this object.

glebs edited the test plan for this revision. (Show Details)

glebs added 1 JIRA issue(s): INP-1410.

Herald added a reviewer: alex. · View Herald TranscriptMar 3 2015, 3:11 AM

alex edited the test plan for this revision. (Show Details)Mar 3 2015, 3:17 AM

alex edited edge metadata.

alex edited the test plan for this revision. (Show Details)

alex added a project: Restricted Project.Mar 27 2016, 6:00 AM

alex retitled this revision from INP-1410 - show_mode section parameter doesn't affect tabs to INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.

alex edited the test plan for this revision. (Show Details)Jul 29 2022, 1:45 AM

Rebase

Harbormaster completed remote builds in B1108: Diff 1076.Jul 29 2022, 1:45 AM

Remove file, added during testing

Harbormaster completed remote builds in B1109: Diff 1077.Jul 29 2022, 1:46 AM

alex accepted this revision.Jul 29 2022, 1:46 AM

This revision is now accepted and ready to land.Jul 29 2022, 1:46 AM

Closed by commit rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's… (authored by alex, committed by ). · Explain WhyNov 9 2022, 9:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/units/admin/admin_tag_processor.php (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	113	16128		Mar 3 2015, 3:11 AM	★	★
Diff 2	1076	16722	Rebase	Jul 29 2022, 1:45 AM	★	★
Diff 3	1077	16722	Remove file, added during testing	Jul 29 2022, 1:46 AM	★	★
Diff 4	1116	16744	rINP16745	Nov 9 2022, 9:28 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 1077

View Options

core/units/admin/admin_tag_processor.php

INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameterClosedPublicActions