Unexpected output: Affected paths: relative - resubmit patch.
⚙ D472 INP-1865 Use cryptographically safe session key generator
Page MenuHomeIn-Portal Phabricator
Differential D472

INP-1865 Use cryptographically safe session key generator
ClosedPublic
Actions

Authored by erik on Jun 17 2024, 9:14 AM.

Details

Reviewers
alex
Commits
rINP16788: Fixes INP-1865 - Use cryptographically safe session key generator
Summary

improved session ID generation logic

Test Plan
  1. Make login to adm.console multiple times. Confirm, that after successful login adm_sid cookie value usually changes.

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1255
Build 1255: arc lint + arc unit

Event Timeline

erik created this revision.Jun 17 2024, 9:14 AM
erik requested review of this revision.Jun 17 2024, 9:14 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 17 2024, 10:05 AM
Closed by commit rINP16788: Fixes INP-1865 - Use cryptographically safe session key generator (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1121116782Jun 17 2024, 9:14 AM
★
★
Diff 2121416786rINP16788Jun 17 2024, 10:05 AM
★
★

Diff 1211

View Options

core/kernel/session/session.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server