Page MenuHomeIn-Portal Phabricator

INP-1859 - Escape MySQL 8.3 keywords
AbandonedPublic

Authored by alex on Jul 19 2025, 7:25 AM.

Details

Reviewers
erik
Test Plan
NOTE: Require In-Commerce module to be installed.
  1. login to the Admin Console
  2. go to the Website & ContentStructure & DataProducts section (you should be on the Products tab)
  3. switch to the Sections tab
  4. add a Sub Products section (category)
  5. go to the Website & ContentStructure & DataProductsSub Products section (you should be on the Products tab)
  6. create a downloadable product in Active status with 1 file in it
  7. login to the Front-End
  8. go to the Products > Sub Products category and buy above-created product
  9. go to the Admin Console
  10. go to the {anv E-commerce > Orders} section (you should be on the Pending tab)
  11. confirm, that just submitted sales order is shown in there
  12. select just submitted sales order
  13. click on the Approve toolbar button
  14. confirm, that:
    • the sales order is longer shown in the Pending orders grid
    • no SQL error about reserved Grouping keyword in MySQL 8.x happened (blocks script execution in Debug Mode)

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated.
SeverityLocationCodeMessage
Errormodules/in-commerce/units/orders/orders_event_handler.php:2898PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/orders/orders_event_handler.php:2898PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/orders/orders_event_handler.php:2898PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/orders/orders_event_handler.php:2898PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Unit
No Unit Test Coverage
Build Status
Buildable 11106
Build 3806: arc lint + arc unit

Event Timeline

alex created this revision.Jul 19 2025, 7:25 AM
alex requested review of this revision.Jul 19 2025, 7:25 AM
erik requested changes to this revision.Tue, Jan 13, 4:51 AM
  1. missing system/downloads folder, so can't save file for downloadable product
  2. on downloadable product creation "Price" field on the "Files & Pricing" tab is not required, but, if this input is missing, SQL error happens when trying buy this product in front-end.

This revision now requires changes to proceed.Tue, Jan 13, 4:51 AM
alex added a comment.EditedTue, Jan 13, 2:07 PM
In D532#11363, @erik wrote:
  1. missing system/downloads folder, so can't save file for downloadable product

Not related to this Differential Revision, but is a bug in In-Portal: using inp_edit_upload block won't auto-create missing upload_dir folder. Please report in Jira instead.

  1. on downloadable product creation "Price" field on the "Files & Pricing" tab is not required, but, if this input is missing, SQL error happens when trying buy this product in front-end.

Not related to this Differential Revision, but is a bug in In-Commerce: price field isn't mandatory. Please report in Jira instead.

After that please Accept this Differential Revision if test passes.

alex requested review of this revision.Tue, Jan 13, 2:07 PM
erik accepted this revision.Wed, Jan 14, 5:29 AM
This revision is now accepted and ready to land.Wed, Jan 14, 5:29 AM
alex abandoned this revision.Wed, Jan 14, 8:24 AM

This appears to be a duplicate of the D547.