Page MenuHomeIn-Portal Phabricator
Differential D539

INP-1923 - Display "Server Hostname" in the System Log
Needs ReviewPublic
Actions

Authored by alex on Mon, Sep 1, 7:05 AM.

Details

Reviewers
erik
Test Plan

Part 1

  1. perform clean install
  2. confirm, that SystemLog.LogServerHostname column exists
  3. perform upgrade
  4. confirm, that SystemLog.LogServerHostname column exists

Part 2

  1. in IDE: add some code, that triggers a notice to the \UsersEventHandler::SetCustomQuery method
  2. login to the Admin Console
  3. go to the User Management → Users section
  4. confirm, that notice(-s) happened
  5. go to the Logs & Reports → System Log section
  6. confirm, that:
    • system log records about above-happened notices are present
    • these system log records have Server Hostname column populated
  7. open any of the system log records with a non-empty Server Hostname column for viewing
  8. confirm, that Server Hostname field is also shown in the system log record viewing popup/modal window

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing.
SeverityLocationCodeMessage
Errorcore/kernel/utility/logger.php:380PHPCS.E.Generic.PHP.SAPIUsage.FunctionFoundGeneric.PHP.SAPIUsage.FunctionFound
Errorcore/units/logs/system_logs/system_logs_config.php:145PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:145PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:146PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:146PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:147PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:147PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:218PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:218PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:219PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:219PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/system_logs/system_logs_config.php:220PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/system_logs/system_logs_config.php:220PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11141
Build 3841: arc lint + arc unit

Event Timeline

alex created this revision.Mon, Sep 1, 7:05 AM
alex requested review of this revision.Mon, Sep 1, 7:05 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1139116855Mon, Sep 1, 7:05 AM
★
★

Diff 1391

View Options

admin/system_presets/simple/system_logs_system-log.php

Loading...
View Options

core/admin_templates/logs/system_logs/system_log_edit.tpl

Loading...
View Options

core/install/english.lang

Loading...
View Options

core/install/install_schema.sql

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

core/kernel/utility/logger.php

Loading...
View Options

core/units/logs/system_logs/system_logs_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server