Page MenuHomeIn-Portal Phabricator
Differential D542

INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Needs RevisionPublic
Actions

Authored by alex on Wed, Sep 3, 11:51 AM.

Details

Reviewers
erik
Test Plan
NOTE: Perform these tests after clean install and after upgrade.
  1. login to the Admin Console
  2. go to the Configuration → Website → Advanced section
  3. enable the Track database changes to change log system setting and save changes
  4. re-login to the Admin Console
  5. go to the Logs & Reports → Session Log section
  6. confirm, that these extra columns are present and aren't empty:
    • Hostname
    • Server Hostname

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated
SeverityLocationCodeMessage
Errorcore/units/logs/session_logs/session_logs_config.php:124PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:124PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:125PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:125PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:126PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:126PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.AfterCodingStandard.WhiteSpace.CommaSpacing.After
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:154PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:154PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:155PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:155PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Warningcore/units/logs/session_logs/session_logs_config.php:153PHPCS.W.CodingStandard.Arrays.Array.LastCommaCodingStandard.Arrays.Array.LastComma
Unit
No Unit Test Coverage
Build Status
Buildable 11154
Build 3854: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Sep 3, 11:51 AM
alex requested review of this revision.Wed, Sep 3, 11:51 AM
erik requested changes to this revision.Wed, Sep 3, 12:25 PM

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

This revision now requires changes to proceed.Wed, Sep 3, 12:25 PM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1140416859Wed, Sep 3, 11:51 AM
★
★

Diff 1404

View Options

core/install/install_schema.sql

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

core/units/logs/session_logs/session_log_eh.php

Loading...
View Options

core/units/logs/session_logs/session_logs_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server