INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection
ClosedPublic
Actions

Authored by alex on Wed, Sep 3, 9:44 AM.

Details

Reviewers

erik

Commits

Test Plan

enable Internet Connection
run the changed test case files
confirm, that:
- all tests were executed
- none of tests were skipped
disable Internet Connection (disconnect the network cable or disable the Wi-Fi)
run the changed test case files
confirm, that:
- all tests were executed
- tests, that require internet connectivity were skipped almost instantly (no 20sec delay for detecting network issues)

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

alex requested review of this revision.Wed, Sep 3, 9:44 AM

This revision is now accepted and ready to land.Wed, Sep 3, 10:47 AM

This revision was landed with ongoing or failed builds.Wed, Sep 3, 11:09 AM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1398	16856		Wed, Sep 3, 9:44 AM	★	★
Diff 2	1401	16857	rINP16858	Wed, Sep 3, 11:09 AM	★	★

Status	Author	Revision
Closed	erik	D509 INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method
Changes Planned	alex	D529 INP-1917 - Validate "kOptionsFormatter::Parse" method values
Closed	alex	D541 INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection
Closed	alex	D540 INP-1925 - Configure PHPUnit integration with Arcanist

			Path	Packages
M			branches/5.2.x/core/tests/Unit/kernel/globalsTest.php (48 lines)
M			branches/5.2.x/core/tests/Unit/kernel/utility/DebuggerUtilTest.php (48 lines)