Differential D541

INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection
ClosedPublic
Actions

Authored by alex on Wed, Sep 3, 9:44 AM.

Details

Reviewers

erik

Commits

rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet…

Test Plan

enable Internet Connection
run the changed test case files
confirm, that:
- all tests were executed
- none of tests were skipped
disable Internet Connection (disconnect the network cable or disable the Wi-Fi)
run the changed test case files
confirm, that:
- all tests were executed
- tests, that require internet connectivity were skipped almost instantly (no 20sec delay for detecting network issues)

Diff Detail

Repository

rINP In-Portal

Branch

branches/5.2.x

Lint

Lint Warnings

Excuse: Without silencing the PHPUnit would catch that warning.

Severity	Location	Code	Message
Warning	core/tests/Unit/kernel/globalsTest.php:33	PHPCS.W.CodingStandard.PHP.NoSilencedErrors.Discouraged	CodingStandard.PHP.NoSilencedErrors.Discouraged
Warning	core/tests/Unit/kernel/utility/DebuggerUtilTest.php:29	PHPCS.W.CodingStandard.PHP.NoSilencedErrors.Discouraged	CodingStandard.PHP.NoSilencedErrors.Discouraged

Unit

Unit Tests OK

Build Status

Buildable 11148
Build 3848: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Sep 3, 9:44 AM

Herald added a reviewer: erik. · View Herald TranscriptWed, Sep 3, 9:44 AM

alex requested review of this revision.Wed, Sep 3, 9:44 AM

Harbormaster completed remote builds in B11148: Diff 1398.Wed, Sep 3, 9:44 AM

alex added a parent revision: D540: INP-1925 - Configure PHPUnit integration with Arcanist.Wed, Sep 3, 9:57 AM

erik accepted this revision.Wed, Sep 3, 10:47 AM

This revision is now accepted and ready to land.Wed, Sep 3, 10:47 AM

This revision was landed with ongoing or failed builds.Wed, Sep 3, 11:09 AM

Closed by commit rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet… (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1398	16856		Wed, Sep 3, 9:44 AM	★	★
Diff 2	1401	16857	rINP16858	Wed, Sep 3, 11:09 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	erik	D509 INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method
Changes Planned	alex	D529 INP-1917 - Validate "kOptionsFormatter::Parse" method values
Closed	alex	D541 INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection
Closed	alex	D540 INP-1925 - Configure PHPUnit integration with Arcanist

Diff 1398

View Options

core/tests/Unit/kernel/globalsTest.php