Page MenuHomeIn-Portal Phabricator

INP-1929 - Increase e-mail template name size
AcceptedPublic

Authored by alex on Wed, Nov 19, 8:29 AM.

Details

Reviewers
erik
Test Plan

Part 1

  1. do a clean install
  2. confirm, that EmailTemplates.TemplateName column size is 255 symbols in the database
  3. login to the Admin Console
  4. go to the Website & ContentE-mail Templates section
  5. attempt to create an e-mail template with name longer than 40 symbols
  6. confirm, that e-mail template was created and it's name renamed as entered
  7. attempt to create an e-mail template with name longer than 255 symbols
  8. confirm, that e-mail template wasn't created and a validation error was shown

Part 2

Repeat same steps as in Part 1, but do an upgrade instead of clean install.

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated.
SeverityLocationCodeMessage
Errorcore/units/email_templates/email_templates_config.php:106PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/email_templates/email_templates_config.php:106PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/email_templates/email_templates_config.php:107PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/email_templates/email_templates_config.php:107PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/email_templates/email_templates_config.php:107PHPCS.E.Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsedGeneric.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Errorcore/units/email_templates/email_templates_config.php:112PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/email_templates/email_templates_config.php:112PHPCS.E.Generic.PHP.LowerCaseConstant.FoundGeneric.PHP.LowerCaseConstant.Found
Errorcore/units/email_templates/email_templates_config.php:112PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11161
Build 3861: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Nov 19, 8:29 AM
alex requested review of this revision.Wed, Nov 19, 8:29 AM
erik accepted this revision.Wed, Nov 19, 10:34 AM
This revision is now accepted and ready to land.Wed, Nov 19, 10:34 AM