Differential D558

INP-1924 - Test Suite freezes when executed without an Internet Connection
ClosedPublic
Actions

Authored by alex on Fri, Feb 20, 2:59 AM.

Details

Reviewers

erik

Commits

rINP16870: Bug INP-1924 - Test Suite freezes when executed without an Internet Connection

Test Plan

Execute the test plan from the D541.

Diff Detail

Repository

rINP In-Portal

Branch

branches/5.2.x

Lint

Lint Warnings

Excuse: On purpose.

Severity	Location	Code	Message
Warning	core/tests/Unit/kernel/globalsTest.php:33	PHPCS.W.CodingStandard.PHP.NoSilencedErrors.Discouraged	CodingStandard.PHP.NoSilencedErrors.Discouraged
Warning	core/tests/Unit/kernel/utility/DebuggerUtilTest.php:29	PHPCS.W.CodingStandard.PHP.NoSilencedErrors.Discouraged	CodingStandard.PHP.NoSilencedErrors.Discouraged

Unit

Unit Tests OK

Build Status

Buildable 11198
Build 3898: arc lint + arc unit

Event Timeline

alex created this revision.Fri, Feb 20, 2:59 AM

Herald added a reviewer: erik. · View Herald TranscriptFri, Feb 20, 2:59 AM

alex requested review of this revision.Fri, Feb 20, 2:59 AM

Harbormaster completed remote builds in B11198: Diff 1447.Fri, Feb 20, 2:59 AM

Harbormaster completed remote builds in B11198: Diff 1447.

alex added a parent revision: D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.Fri, Feb 20, 3:00 AM

erik accepted this revision.Fri, Feb 20, 5:12 AM

This revision is now accepted and ready to land.Fri, Feb 20, 5:12 AM

This revision was landed with ongoing or failed builds.Fri, Feb 20, 11:04 AM

Closed by commit rINP16870: Bug INP-1924 - Test Suite freezes when executed without an Internet Connection (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1447	16869		Fri, Feb 20, 2:59 AM	★	★
Diff 2	1450	16869	rINP16870	Fri, Feb 20, 11:04 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	erik	D509 INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method
Changes Planned	alex	D529 INP-1917 - Validate "kOptionsFormatter::Parse" method values
Closed	alex	D558 INP-1924 - Test Suite freezes when executed without an Internet Connection
Closed	alex	D541 INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection
Closed	alex	D540 INP-1925 - Configure PHPUnit integration with Arcanist

Diff 1447

View Options

core/tests/Unit/kernel/globalsTest.php