Testing in progress, not finished. Cant normally upgrade from 5.1.c to 5.2.x. -

Patching to 5.2.2-B2 version:

Hunk #1 FAILED at 801.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/skin_css_8ikYD3.rej

Removed old Id hardcoding.

Tested, all tests passed, excepting Test2 in part "value after T_ADD_VAR[test]: haven't changed" - this value changed in this test
https://www.screencast.com/t/25QIBxii

Part 1 test not passed. - https://www.screencast.com/t/n8hWHlZ8zes

Fixed notices.

Made all requested improvements.

Today written locally all requested changes code, not tested, stored to Shelf.

Made requested changes to category helper.

At part 3 resulting thumbnail size was not 100x100, but was 120x120.
At part 4 resulting thumbnail size was not 75x100, but was 90x120 (screenshot added for this case).

Reverted change of Enabled field name.

All works properly, but test plan may be corrected:
Part 1, 13 - may be "confirm, that in Console 3 messages about change event appeared (for 2 option checkboxes + select all itself)" - because by previous part of the plan 2 options were unchecked.

Tested with system log enabled. No deprecation warnings found. All system log messages, got when testing, displayed on screenshot -

All tests passed, excepting creating records about deprecated calls in the System Log - on tests such records never created. System Log is empty.

All right, but when upgrading from 5.1.x to 5.2.x with debugger enabled, got lot of error messages on all installation steps from 1st to 6th. Like "Table SystemLog doesn't exist"

Today made locally all requested changes, left testing by plan.

Tested with image

Tested also by D307 plan.

Test failed in the Part 4 "confirm, that image preview is displayed". Image preview not displayed. Image uploaded in the /system/images/pending/ folder, and with "/system/images/pending/{image file name}" value in DB.

Some issues on test plan:

Today tested parts 1..3 only.

Made upgrade SQL optimization.

Made all necessary fixes.

Made all requested fixes.

Filled AddedOn date in themes table.

Set AddedOn values for themes on install/upgrade.

Made all requested fixes.

Made all requested CS and logic fixes.

Made all requested changes.

today made all code changes, but not tested by plan yet

Last test in Part2 not passed. Got validation errors "bad_date_format" on CreatedOn field.

There were much of SQL errors like

Test plan must be fixed. "Enable Debug Mode in /system/debug.php file" must be added somewhere between Part 2 and Part 3. Otherwise at Part 3 Debug Mode is disabled and confirmation about appearance of notices is not possible - notices does not appear.

Tasted also on https://www.browserstack.com (IE8 part)

Tested all with IE10. Tested with IE8, as browser mode of IE10 (through IE8 mode selection in developer tools).