Page MenuHomeIn-Portal Phabricator
Feed All Stories

Dec 6 2015

alex added a child revision for D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D169: INP-1517 - Define INDEX_FILE constant in each CLI script: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D179: INP-1523 - Populate user info, when sending membership expiration e-mails: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Rollback changes, that were added through applying another needed patch.

Dec 6 2015, 8:32 AM
alex retitled D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI from to INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:16 AM
alex updated the diff for D179: INP-1523 - Populate user info, when sending membership expiration e-mails.

Forgot to add language pack changes

Dec 6 2015, 7:45 AM
alex retitled D179: INP-1523 - Populate user info, when sending membership expiration e-mails from to INP-1523 - Populate user info, when sending membership expiration e-mails.
Dec 6 2015, 7:42 AM
alex retitled D178: INP-1524 - Disable auto-complete on password fields on user creation page from to INP-1524 - Disable auto-complete on password fields on user creation page.
Dec 6 2015, 7:11 AM

Dec 5 2015

alex retitled D177: INP-1522 - Adapt error output for CLI from to INP-1522 - Adapt error output for CLI.
Dec 5 2015, 1:24 PM
alex retitled D176: MINL-18 - Change link categories automatically according to it's Listing Type from to MINL-18 - Link isn't added/removed to category specified in Listing Type.
Dec 5 2015, 10:11 AM
alex retitled D175: INP-1521 - Don't expose InitList and PrintList tag communication to Web Request from to INP-1521 - Don't expose InitList and PrintList tag communication to Web Request.
Dec 5 2015, 8:32 AM

Dec 4 2015

glebs accepted D172: MINN-10 - Don't use Web Request during Article adding/editing.
Dec 4 2015, 2:53 AM

Dec 2 2015

glebs accepted D171: INP-1519 - Generate e-mail access key after subject is prepared.
Dec 2 2015, 2:01 AM
glebs accepted D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method.
Dec 2 2015, 1:51 AM
glebs accepted D169: INP-1517 - Define INDEX_FILE constant in each CLI script.
Dec 2 2015, 1:39 AM

Nov 30 2015

glebs accepted D168: INP-1515 - Allow to enable/disable the Site Domain.
Nov 30 2015, 2:03 AM · Restricted Project

Nov 27 2015

glebs accepted D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 27 2015, 2:54 AM · Restricted Project

Nov 19 2015

glebs updated the test plan for D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.
Nov 19 2015, 2:30 AM · Restricted Project
glebs updated the diff for D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.

Made requested changes

Nov 19 2015, 2:28 AM · Restricted Project

Nov 18 2015

alex updated the test plan for D174: INP-1520 - Honor manually set owner of categories/category items created from CLI.
Nov 18 2015, 2:34 PM
alex retitled D174: INP-1520 - Honor manually set owner of categories/category items created from CLI from to INP-1520 - Honor manually set owner of categories/category items created from CLI.
Nov 18 2015, 2:34 PM
alex retitled D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field from to MINN-11 - Specify category for RSS feed articles via "CategoryId" field.
Nov 18 2015, 7:23 AM
alex retitled D172: MINN-10 - Don't use Web Request during Article adding/editing from to MINN-10 - Don't use Web Request during Article adding/editing.
Nov 18 2015, 6:36 AM

Nov 17 2015

alex retitled D171: INP-1519 - Generate e-mail access key after subject is prepared from to INP-1519 - Generate e-mail access key after subject is prepared.
Nov 17 2015, 2:17 PM
alex committed rTBST16303: Releasing version 'branches/1.0.x' (copy from 'trunk') of 'themes/bootstrap'….
Releasing version 'branches/1.0.x' (copy from 'trunk') of 'themes/bootstrap'…
Nov 17 2015, 5:55 AM
alex committed rTBST16302: Bug TBST-1 - Create theme in repository.
Bug TBST-1 - Create theme in repository
Nov 17 2015, 5:44 AM
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 4:49 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive line, improved test plan before this revision

Nov 17 2015, 4:29 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 4:21 AM · Restricted Project
alex accepted D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:12 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:11 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:11 AM · Restricted Project
alex added inline comments to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 3:10 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

The test plan wasn't changed as requested.

Nov 17 2015, 3:04 AM · Restricted Project
alex added a parent revision for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method: D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:35 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:35 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:34 AM · Restricted Project

Nov 16 2015

alex retitled D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method from to INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method.
Nov 16 2015, 3:03 PM
alex retitled D169: INP-1517 - Define INDEX_FILE constant in each CLI script from to INP-1517 - Define INDEX_FILE constant in each CLI script.
Nov 16 2015, 2:37 PM
alex updated the test plan for D168: INP-1515 - Allow to enable/disable the Site Domain.
Nov 16 2015, 11:24 AM · Restricted Project
alex retitled D168: INP-1515 - Allow to enable/disable the Site Domain from to INP-1515 - Allow to enable/disable the Site Domain.
Nov 16 2015, 11:24 AM · Restricted Project
erik updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:39 AM · Restricted Project
erik retitled D167: INP-1514 Reset validation errors before object loading from to INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:33 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed Clear() calls, added in the previous version of revision.

Nov 16 2015, 4:20 AM · Restricted Project
glebs requested review of D3: INP-1381 - Create special template for fatal error page.
Nov 16 2015, 3:14 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

... added Clear() calls to fit new plan.

Nov 16 2015, 3:04 AM · Restricted Project

Nov 14 2015

alex added a comment to D3: INP-1381 - Create special template for fatal error page.

Just send revision for review somehow without making any code changes.

Nov 14 2015, 8:35 AM · Restricted Project

Nov 13 2015

alex requested changes to D3: INP-1381 - Create special template for fatal error page.
Nov 13 2015, 4:43 AM · Restricted Project
alex requested changes to D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.

The test plan:

  • doesn't include steps for testing clean install/upgrade
  • doesn't work (I've tried to do as written in test plan and problem is still there)
Nov 13 2015, 3:23 AM · Restricted Project
glebs retitled D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control from to INP-1513 Fix wrong line wrapping in inp_edit_checkboxes.
Nov 13 2015, 2:12 AM · Restricted Project

Nov 11 2015

alex accepted D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 6:38 AM · Restricted Project
erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Fixed SQL code indent

Nov 11 2015, 6:18 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Code tested according to plan. Please do that last cosmetical change and we're done here.

Nov 11 2015, 5:10 AM · Restricted Project
alex updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 5:05 AM · Restricted Project
alex updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 5:01 AM · Restricted Project

Nov 10 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Removed new helper, made inline code with count() in cycle conditions

Nov 10 2015, 11:45 AM · Restricted Project
alex added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 10 2015, 5:23 AM · Restricted Project
erik added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 10 2015, 4:58 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Changed test plan, added Clear() calls to fit new plan.

Nov 10 2015, 4:39 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 10 2015, 4:34 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Please thoroughly look through each comment I leave (every time on every revision). If you decide not to do as I've advised, then please explain why as a reply to relevant comment.

Nov 10 2015, 4:15 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
  1. add temporary line "$event->status = kEvent::erFAIL;" to CategoriesEventHandler::OnBeforeItemUpdate
  2. confirm that Approve and Decline buttons do not change Status for categories, but also no fatal error happens
  3. remove temporary line "$event->status = kEvent::erFAIL;" from CategoriesEventHandler::OnBeforeItemUpdate
Nov 10 2015, 2:27 AM · Restricted Project

Nov 9 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested code formatting

Nov 9 2015, 9:53 AM · Restricted Project
alex added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 9:18 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

The test plan seems to out of sync with reality this time as well.

Nov 9 2015, 9:15 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 9:12 AM · Restricted Project
erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested changes for code optimization

Nov 9 2015, 7:48 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 6:59 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Aside from inline comments following needs to be fixed in the test plan as well:

Nov 9 2015, 5:19 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive code from shipping_quote_engine_event_handler.php

Nov 9 2015, 5:04 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 9 2015, 4:53 AM · Restricted Project

Nov 6 2015

erik retitled D165: INP-1510 Allow rotation of "Session Log" and "Changes Log" from to INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 6 2015, 11:24 AM · Restricted Project
alex updated the test plan for D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 6 2015, 9:00 AM · Restricted Project
alex requested review of D161: INP-1509 - Change concept used for category path matching to module root category.

Please re-test.

Nov 6 2015, 8:54 AM · Restricted Project
alex updated the diff for D161: INP-1509 - Change concept used for category path matching to module root category.

Selecting Structure & Data category wasn't causing tab auto-switching.

Nov 6 2015, 8:54 AM · Restricted Project
alex planned changes to D161: INP-1509 - Change concept used for category path matching to module root category.

The Sections tab isn't activated when topmost section (the Structure & Data) is clicked.

Nov 6 2015, 8:35 AM · Restricted Project

Nov 5 2015

alex accepted D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 5 2015, 10:52 AM · Restricted Project
erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Removed excessive IncludeFieldTitles checkbox.

Nov 5 2015, 10:31 AM · Restricted Project
erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Moved configuration fields ro requested places

Nov 5 2015, 9:09 AM · Restricted Project
alex requested changes to D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 5 2015, 5:15 AM · Restricted Project
erik updated the diff for D158: INP-1487 Create empty search result table, when search keyword is too short.

Used getSearchTable method in additional places

Nov 5 2015, 4:56 AM · Restricted Project
erik updated the test plan for D158: INP-1487 Create empty search result table, when search keyword is too short.
Nov 5 2015, 4:46 AM · Restricted Project
alex requested changes to D158: INP-1487 Create empty search result table, when search keyword is too short.

Also test plan doesn't cover code path, that caused search table removal in past (e.g. make search that finds something and then make search with short/empty keyword).

Nov 5 2015, 2:48 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
  1. test plan is missing tests, that demonstrate, that problem, described in Confluence, no longer happen under same conditions
  2. please remove ShippingQuoteEngineEventHandler::iterateItems method because the only thing it does it rolling back event status change, that no longer happens in parent class method
Nov 5 2015, 2:36 AM · Restricted Project
glebs accepted D164: MINC-135 - Use shipping type from Order, when editing in Admin Console.
Nov 5 2015, 2:22 AM · Restricted Project

Nov 4 2015

alex retitled D164: MINC-135 - Use shipping type from Order, when editing in Admin Console from to MINC-135 - Use shipping type from Order, when editing in Admin Console.
Nov 4 2015, 8:37 AM · Restricted Project
glebs accepted D163: INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value.
Nov 4 2015, 1:51 AM · Restricted Project

Nov 3 2015

erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Made required fixes

Nov 3 2015, 9:28 AM · Restricted Project
alex retitled D163: INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value from to INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value.
Nov 3 2015, 8:42 AM · Restricted Project
alex requested changes to D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 3 2015, 5:51 AM · Restricted Project
erik updated the test plan for D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 3 2015, 5:16 AM · Restricted Project

Nov 2 2015

erik retitled D162: INP-1511 - Add "export presets" support for category items export dialogs from to INP-1511 Presets for category items export.
Nov 2 2015, 9:47 AM · Restricted Project
glebs accepted D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 2 2015, 1:59 AM · Restricted Project

Oct 30 2015

alex retitled D161: INP-1509 - Change concept used for category path matching to module root category from to INP-1509 - Change concept used for category path matching to module root category.
Oct 30 2015, 11:43 AM · Restricted Project

Oct 29 2015

glebs accepted D159: INP-1508 - Enable non-sortable grid column title wrapping.
Oct 29 2015, 2:28 AM · Restricted Project

Oct 28 2015

glebs accepted D157: INP-1507 - Flush OpCode cache for /system/config.php when it's changed.
Oct 28 2015, 4:04 AM

Oct 27 2015

glebs accepted D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.
Oct 27 2015, 3:07 AM

Oct 26 2015

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Applued additional patch, made other requested changes.

Oct 26 2015, 6:01 AM · Restricted Project
erik updated the test plan for D120: INP-1470 - Google Sitemap support.
Oct 26 2015, 5:33 AM · Restricted Project