Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Apr 25 2017

erik updated the diff for D297: INP-1692 - Allow searching pages by their Content Block content.

Made all requested fixes.

Apr 25 2017, 6:07 AM

Apr 24 2017

erik retitled D297: INP-1692 - Allow searching pages by their Content Block content from to INP-1692 Allow searching pages by their Content Block content.
Apr 24 2017, 9:38 AM

Apr 14 2017

erik updated the diff for D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Filled AddedOn date in themes table.

Apr 14 2017, 6:37 AM
erik updated the diff for D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Set AddedOn values for themes on install/upgrade.

Apr 14 2017, 6:00 AM

Apr 13 2017

erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 13 2017, 6:06 AM · Restricted Project
erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Made all requested fixes.

Apr 13 2017, 6:05 AM · Restricted Project

Apr 12 2017

erik updated the diff for D11: INP-1313 - Add support for copying content blocks between themes.

Made all requested CS and logic fixes.

Apr 12 2017, 6:06 AM
erik updated the test plan for D11: INP-1313 - Add support for copying content blocks between themes.
Apr 12 2017, 5:49 AM

Apr 11 2017

erik added inline comments to D11: INP-1313 - Add support for copying content blocks between themes.
Apr 11 2017, 5:39 AM

Apr 10 2017

erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Made all requested changes.

Apr 10 2017, 6:07 AM · Restricted Project
erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 10 2017, 5:42 AM · Restricted Project
erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 10 2017, 5:41 AM · Restricted Project

Apr 6 2017

erik added a comment to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

today made all code changes, but not tested by plan yet

Apr 6 2017, 6:00 AM · Restricted Project

Apr 5 2017

erik accepted D286: INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter.
Apr 5 2017, 5:33 AM · Restricted Project
erik accepted D287: INP-1682 - Make "kFormatter::TypeCast" to return "false" when value (not type) is changed.
Apr 5 2017, 5:28 AM
erik accepted D290: INP-1684 - Ignore hidden columns during grid column width saving.
Apr 5 2017, 5:19 AM · Restricted Project

Apr 4 2017

erik accepted D292: INP-1686 - Don't include timestamp in compiled Admin Skin file.
Apr 4 2017, 6:01 AM
erik accepted D293: INP-1688 - Support both "%s" and "{param_name}" in validation error messages.
Apr 4 2017, 5:45 AM
erik accepted D294: INP-1689 - Use clever scrolling when editing is done in "Same Window" mode.
Apr 4 2017, 5:25 AM · Restricted Project

Mar 30 2017

erik accepted D285: INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method.
Mar 30 2017, 1:15 PM · Restricted Project

Mar 17 2017

erik accepted D291: INP-1685 - Handle date fields during CSV import.
Mar 17 2017, 5:22 AM · Restricted Project

Mar 14 2017

erik requested changes to D291: INP-1685 - Handle date fields during CSV import.

Last test in Part2 not passed. Got validation errors "bad_date_format" on CreatedOn field.

Mar 14 2017, 5:29 AM · Restricted Project

Jan 31 2017

erik accepted D282: INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method.
Jan 31 2017, 5:01 AM

Jan 30 2017

erik accepted D283: INP-1666 - Move "EDITING_MODE" constant definition to "adm:OnStartup" event hook.
Jan 30 2017, 5:10 AM · Restricted Project
erik accepted D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jan 30 2017, 4:45 AM

Jan 23 2017

erik accepted D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.
Jan 23 2017, 4:12 AM · Restricted Project

Jan 13 2017

erik accepted D280: INP-1663 - Register missing classes in class factory V2.
Jan 13 2017, 4:32 AM

Jan 11 2017

erik accepted D281: INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL.

There were much of SQL errors like

Jan 11 2017, 5:05 AM · Restricted Project

Jan 10 2017

erik accepted D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.
Jan 10 2017, 4:49 AM
erik accepted D276: INP-1662 - Add methods for handling deprecations.
Jan 10 2017, 4:36 AM

Jan 4 2017

erik accepted D274: INP-1660 - Make CKEditor styles dropdown larger.
Jan 4 2017, 5:05 AM · Restricted Project
erik accepted D275: INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it.
Jan 4 2017, 4:47 AM · Restricted Project
erik requested changes to D276: INP-1662 - Add methods for handling deprecations.

Test plan must be fixed. "Enable Debug Mode in /system/debug.php file" must be added somewhere between Part 2 and Part 3. Otherwise at Part 3 Debug Mode is disabled and confirmation about appearance of notices is not possible - notices does not appear.

Jan 4 2017, 4:32 AM
erik accepted D273: INP-1659 - Add HTML5 runtime to Plupload options.

Tasted also on https://www.browserstack.com (IE8 part)

Jan 4 2017, 4:09 AM · Restricted Project

Dec 28 2016

erik accepted D273: INP-1659 - Add HTML5 runtime to Plupload options.

Tested all with IE10. Tested with IE8, as browser mode of IE10 (through IE8 mode selection in developer tools).

Dec 28 2016, 5:07 AM · Restricted Project

Dec 23 2016

erik retitled D272: INP-1657 - Reposition CMS page revision history dropdown automatically from to INP-1657 Reposition CMS page revision history dropdown automatically.
Dec 23 2016, 4:49 AM
erik accepted D271: INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown.
Dec 23 2016, 4:07 AM · Restricted Project

Dec 22 2016

erik updated the test plan for D73: INP-1433 - Handle resource type in Debugger.
Dec 22 2016, 4:44 AM · Restricted Project
erik updated the test plan for D270: INP-1654 Handle resource type in System Log.
Dec 22 2016, 4:35 AM
erik retitled D270: INP-1654 Handle resource type in System Log from to INP-1654 Handle resource type in System Log.
Dec 22 2016, 4:34 AM

Dec 21 2016

erik accepted D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.
Dec 21 2016, 4:24 AM · Restricted Project

Dec 8 2016

erik accepted D268: INP-1656 - Emulate SVG file resize in "ImageHelper".
Dec 8 2016, 4:51 AM

Dec 7 2016

erik added a comment to D120: INP-1470 - Google Sitemap support.

Today made all necessary changes locally, started writing additions to the test plan.

Dec 7 2016, 5:02 AM · Restricted Project

Dec 6 2016

erik added a comment to D120: INP-1470 - Google Sitemap support.

Today only re-applied differential patch and re-installed local version of 5.3.x In-Portal with this patch.

Dec 6 2016, 5:07 AM · Restricted Project
erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Patch rebuilt for 5.2.x version.

Dec 6 2016, 4:44 AM · Restricted Project

Dec 5 2016

erik added a comment to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Today looks that made all necessary changes, but not full-tested yet. Left part of tests planned on next day.

Dec 5 2016, 5:38 AM · Restricted Project

Dec 2 2016

erik updated the diff for D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.

Rebuilt in In-Portal 5.2.x.

Dec 2 2016, 4:43 AM
erik updated the test plan for D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Dec 2 2016, 4:30 AM
erik requested changes to D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.

Not confirmed test Part2, in Admin Console, item N4 "in heading: parent section icon and name, and on next row extra heading text". In fact, extra heading text is on top, section header - next line after extra heading text - in reverse order from defined in test plan.

Dec 2 2016, 3:31 AM

Nov 30 2016

erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Fixed CS errors.

Nov 30 2016, 5:19 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Nov 30 2016, 5:01 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Nov 30 2016, 5:01 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Nov 30 2016, 4:57 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Nov 30 2016, 4:55 AM

Nov 29 2016

erik updated the diff for D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.

Fixed class name in the @var type comment

Nov 29 2016, 4:55 AM · Restricted Project
erik accepted D265: INP-1643 - Use relative paths in "my_document" CKEditor plugin.
Nov 29 2016, 4:52 AM
erik accepted D266: INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Nov 29 2016, 4:52 AM

Nov 28 2016

erik added a comment to D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

There were errors when applying patch (through arc patch D253 command). Some changes not apply automatically. Applied manually before tests.

Nov 28 2016, 5:08 AM · Restricted Project
erik accepted D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.
Nov 28 2016, 4:57 AM · Restricted Project

Nov 24 2016

erik requested changes to D256: INP-1325 - Perform intellectual cache update on category changes.

Detected bug, when one admin user opens to edit category1 with relatively big TreeLeft/TreeRight numbers. Then second admin user moves subtree, where category1 is a leaf to the zone of smaller TreeLeft/TreeTight numbers. Then, first user saves category1 and old, big TreeLeft/TreeRight numbers becomes saved to the zone of small TreeLeft/TreeRight numbers, breaking Treeleft BETWEEN A AND B logic.

Nov 24 2016, 5:37 AM · Restricted Project

Nov 22 2016

erik accepted D255: INP-1593 - Auto-detect format of provided password in "kPasswordFormatter::hashPassword" method for migrated users.
Nov 22 2016, 7:43 AM · Restricted Project
erik accepted D257: INP-1594 - Generate/check category filename after page protection code was executed.
Nov 22 2016, 6:59 AM
erik accepted D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.

Mentioned above not a bug. Clearing editor area after each step helps to avoid link merging problem.

Nov 22 2016, 6:37 AM
erik requested changes to D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

Nov 22 2016, 6:28 AM
erik accepted D261: INP-1502 - Gracefully handle case of missing file/line keys in stack trace info.
Nov 22 2016, 5:39 AM
erik accepted D262: INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug::GetIterator" method.
Nov 22 2016, 5:35 AM
erik accepted D264: INP-1642 - Allow "kColumnPickerHelper" class to correctly reorder/resize multilingual columns.
Nov 22 2016, 5:23 AM

Nov 21 2016

erik added a comment to D256: INP-1325 - Perform intellectual cache update on category changes.

Today partially tested part of part 1. Only actions for leaf operation with enabled "Recycle Bin". No bugs found.

Nov 21 2016, 8:56 AM · Restricted Project

Nov 16 2016

erik accepted D258: INP-1595 - Allow uploading Microsoft Office 2007+ generated files in CKFinder.

Tested. For last 2 extension made fake files - changed extension of another type powerpoint file. All files, used in tests are attached to the related JIRA issue.

Nov 16 2016, 4:42 AM · Restricted Project

Nov 14 2016

erik added a comment to D258: INP-1595 - Allow uploading Microsoft Office 2007+ generated files in CKFinder.

Tested today docx,dotx,docm,dotm,xlsx,xltx,xlsm,xltm,xlam,xlsb,pptx,potx,ppsx, stuck on finding file sample with ppam extension.

Nov 14 2016, 12:57 PM · Restricted Project

Nov 11 2016

erik requested changes to D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

SQL error happens when trying open window to edit image. There differs table names, adressed by SQL request and created in DB. See attached screenshots of SQL error and PMA tables list. On screenshot table name, created in DB, has additional element "_12" after SID.

Nov 11 2016, 4:59 AM · Restricted Project
erik accepted D254: INP-1591 - Explicitly set 0px top margin for Modal Window iframes.
Nov 11 2016, 4:30 AM · Restricted Project

Nov 10 2016

erik added a comment to D256: INP-1325 - Perform intellectual cache update on category changes.

Typical test SQL is mentioned in the test plan. That is - TreeLeft BETWEEN A AND B. On screenshot with red are marked values A, B and TreeLeft, which results in wrong result. Red-marked TreeLeft is in C_BUG record, it is not between A and B, marked with red in grandparent of C_BUG record.

Nov 10 2016, 7:40 AM · Restricted Project
erik requested changes to D256: INP-1325 - Perform intellectual cache update on category changes.

Bug detected - after adding leaf, and then another leaf under previous leaf, we got situation when subchildren TreeLeft is not between grandparent's TreeLeft and TreeRight

Nov 10 2016, 5:20 AM · Restricted Project

Oct 24 2016

erik accepted D251: INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.
Oct 24 2016, 4:14 AM · Restricted Project
erik accepted D252: INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons.
Oct 24 2016, 4:07 AM · Restricted Project

Oct 21 2016

erik accepted D249: INP-1585 - Take value of "style" parameter of "inp_edit_multioptions" block into account.
Oct 21 2016, 4:17 AM · Restricted Project
erik accepted D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.
Oct 21 2016, 4:08 AM · Restricted Project

Oct 19 2016

erik accepted D248: INP-1584 - Add readonly mode to "st:ContentBlock" tag.
Oct 19 2016, 4:08 AM · Restricted Project

Oct 17 2016

erik accepted D247: INP-1583 - Add support for "Content Templates" inside CKEditor.
Oct 17 2016, 5:05 AM · Restricted Project

Oct 13 2016

erik accepted D246: INP-1582 - Disable "codemirror" CKEditor add-on during inline Content Block editing.
Oct 13 2016, 4:48 AM · Restricted Project

Sep 13 2016

erik requested review of D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 13 2016, 4:09 AM
erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 13 2016, 4:09 AM

Sep 9 2016

erik planned changes to D5: TADV-34 - Incorrect usage of "block_no_data" attribute.

Needs changes in test plan

Sep 9 2016, 5:27 AM
erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 9 2016, 5:16 AM
erik updated the diff for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.

Removed excessive block_no_data parameter from tags in cancel_recurring and cancel_recurring_ok templates.

Sep 9 2016, 5:15 AM

Sep 8 2016

erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 8 2016, 4:57 AM

Aug 25 2016

erik requested review of D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 8:46 AM
erik updated the test plan for D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 8:43 AM
erik retitled D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method from to INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 4:18 AM

Aug 23 2016

erik accepted D244: INP-1581 - Load email sender/recipient from live table.
Aug 23 2016, 4:17 AM

Aug 19 2016

erik accepted D242: INP-1580 - Set current user ID to current frame for Change Password dialog.
Aug 19 2016, 4:30 AM
erik accepted D240: INP-1577 - CS fix all variable type comment.
Aug 19 2016, 4:29 AM
erik accepted D241: INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache.
Aug 19 2016, 4:28 AM

Aug 10 2016

erik retitled D243: INP-1571 Form field validation should account for array-like field values from to INP-1571 Form field validation should account for array-like field values.
Aug 10 2016, 6:24 AM

Aug 5 2016

erik retitled D239: MINC-177 - Don't send "ORDER.SHIP" email, when email address is missing from to MINC-177 Don't send "ORDER.SHIP" email, when email address is missing.
Aug 5 2016, 5:21 AM

Aug 4 2016

erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

New code moved into "body" tag.

Aug 4 2016, 4:52 AM · Restricted Project
erik accepted D238: MINC-179 - Remove order id/object after the end of checkout process.

No problems found with changed code.

Aug 4 2016, 4:30 AM

Aug 3 2016

erik requested changes to D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.

Some tests failed.

  1. Preparations - "confirm, that Properties tab is visible" - Properties tab is visible, but is not active. Test supposes that Properties must be active - it tells click on Permissions tab to select it.
  2. Part 2 (with mod-rewrite) - "confirm, that clicked link detail page was opened" - not opened. Opened "404 not found" page. When link is under links directory - detail page opens normally. Under home - 404 not found.
Aug 3 2016, 4:51 AM

Aug 2 2016

erik requested changes to D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.

All tests done. No more errors found, excepting reported on Mon, Jul 25, 04:57.

Aug 2 2016, 6:02 AM