Page MenuHomeIn-Portal Phabricator
Feed All Stories

Jul 20 2022

alex requested review of D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
In D401#7949, @erik wrote:

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
Jul 20 2022, 2:46 AM · Restricted Project
alex updated the test plan for D421: MINN-27 - Add missing export-related virtual fields.
Jul 20 2022, 2:45 AM
alex requested review of D421: MINN-27 - Add missing export-related virtual fields.
Jul 20 2022, 2:42 AM
alex added "INP-1791" JIRA issue(s) to rINP16718: Fixes INP-1791 - Add "picker" control type for configuration settings.
Jul 20 2022, 2:09 AM
alex committed rINP16718: Fixes INP-1791 - Add "picker" control type for configuration settings.
Fixes INP-1791 - Add "picker" control type for configuration settings
Jul 20 2022, 2:09 AM
alex closed D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 20 2022, 2:09 AM · Restricted Project
alex added "INP-1812" JIRA issue(s) to rINP16717: Fixes INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at….
Jul 20 2022, 2:06 AM
alex committed rINP16717: Fixes INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at….
Fixes INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at…
Jul 20 2022, 2:06 AM
alex closed D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 20 2022, 2:06 AM

Jul 19 2022

erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Added code to avoid "Array to string conversion" notice. Added related test plan part.

Jul 19 2022, 9:53 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Jul 19 2022, 9:46 AM
erik accepted D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 7:58 AM · Restricted Project
erik accepted D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 7:56 AM
alex requested changes to D243: INP-1571 Form field validation should account for array-like field values.
  1. Please keep the current test plan and add another test plan part covering original scenario from associated Confluence discussion:
Jul 19 2022, 7:51 AM
alex added "INP-1816" JIRA issue(s) to rINP16716: Fixes INP-1816 - Use argument-based cache in the "kApplication….
Jul 19 2022, 6:11 AM
alex committed rINP16716: Fixes INP-1816 - Use argument-based cache in the "kApplication….
Fixes INP-1816 - Use argument-based cache in the "kApplication…
Jul 19 2022, 6:11 AM
alex closed D419: INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method.
Jul 19 2022, 6:11 AM · Restricted Project
alex added "INP-1815" JIRA issue(s) to rINP16715: Fixes INP-1815 - Anonymize error message content for Regular Website Visitors.
Jul 19 2022, 6:08 AM
alex committed rINP16715: Fixes INP-1815 - Anonymize error message content for Regular Website Visitors.
Fixes INP-1815 - Anonymize error message content for Regular Website Visitors
Jul 19 2022, 6:08 AM
alex added "INP-1814" JIRA issue(s) to rINP16714: Fixes INP-1814 - Use relative paths in error messages.
Jul 19 2022, 6:04 AM
alex committed rINP16714: Fixes INP-1814 - Use relative paths in error messages.
Fixes INP-1814 - Use relative paths in error messages
Jul 19 2022, 6:04 AM
alex added "INP-1645" JIRA issue(s) to rINP16713: Fixes INP-1645 - Create categories during theme scan based on their location in….
Jul 19 2022, 6:00 AM
alex committed rINP16713: Fixes INP-1645 - Create categories during theme scan based on their location in….
Fixes INP-1645 - Create categories during theme scan based on their location in…
Jul 19 2022, 6:00 AM
alex closed D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 19 2022, 6:00 AM
alex retitled D269: INP-1645 - Create categories during theme scan based on their location in SMS from INP-1645 Create categories during theme scan based on their location in SMS to INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 19 2022, 5:45 AM
alex requested review of D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
In D416#8350, @erik wrote:

Работает всё как надо, но наверное надо исправить Test Plan. В "Plan 2" и "Plan 3" в SQL не хватает фильтра WHERE ((52x_Users.UserType = 0))

Jul 19 2022, 5:41 AM
alex updated the test plan for D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 5:39 AM
alex updated the test plan for D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 5:38 AM
alex requested review of D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 5:16 AM · Restricted Project
alex added a comment to D388: INP-1791 - Add "picker" control type for configuration settings.

In the test plan part 4 need "Picker" value, not "Checkboxes"

Jul 19 2022, 5:15 AM · Restricted Project
alex updated the test plan for D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 4:54 AM · Restricted Project
alex updated the test plan for D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 4:54 AM · Restricted Project

Jul 15 2022

erik requested changes to D388: INP-1791 - Add "picker" control type for configuration settings.
  1. In the test plan part 4 need "Picker" value, not "Checkboxes"
  2. However, if "Checkboxes" selected, looks incorrect - shown only one checkbox, not multiple checkboxes with one-two-three labels.
  3. Items alphabetical sorting is not applied on page load, so after save/on page reload options order may change.
Jul 15 2022, 12:48 PM · Restricted Project

Jul 14 2022

erik requested changes to D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.

Работает всё как надо, но наверное надо исправить Test Plan. В "Plan 2" и "Plan 3" в SQL не хватает фильтра WHERE ((52x_Users.UserType = 0))

Jul 14 2022, 10:35 AM
erik accepted D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 14 2022, 10:09 AM
erik accepted D419: INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method.
Jul 14 2022, 9:19 AM · Restricted Project

Jul 8 2022

alex committed rINP16712: Fixes INP-1792 - Support HTML markup with Title Presets.
Fixes INP-1792 - Support HTML markup with Title Presets
Jul 8 2022, 9:42 AM
alex added "INP-1792" JIRA issue(s) to rINP16712: Fixes INP-1792 - Support HTML markup with Title Presets.
Jul 8 2022, 9:42 AM
alex closed D390: INP-1792 - Support HTML markup with Title Presets.
Jul 8 2022, 9:42 AM
alex added "INP-1794" JIRA issue(s) to rINP16711: Fixes INP-1794 - Show database query execution times during deployment.
Jul 8 2022, 9:39 AM
alex committed rINP16711: Fixes INP-1794 - Show database query execution times during deployment.
Fixes INP-1794 - Show database query execution times during deployment
Jul 8 2022, 9:39 AM
alex closed D392: INP-1794 - Show database query execution times during deployment.
Jul 8 2022, 9:39 AM · Restricted Project
alex retitled D392: INP-1794 - Show database query execution times during deployment from INP-1794 - Show database query execution times durning deployment to INP-1794 - Show database query execution times during deployment.
Jul 8 2022, 9:39 AM · Restricted Project
alex added "INP-1796" JIRA issue(s) to rINP16710: Fixes INP-1796 - Add method for setting database error handler.
Jul 8 2022, 9:36 AM
alex committed rINP16710: Fixes INP-1796 - Add method for setting database error handler.
Fixes INP-1796 - Add method for setting database error handler
Jul 8 2022, 9:36 AM
alex closed D394: INP-1796 - Add method for setting database error handler.
Jul 8 2022, 9:36 AM
alex added "INP-1797" JIRA issue(s) to rINP16709: Fixes INP-1797 - Speed up formatter class access from "kDBItem".
Jul 8 2022, 9:29 AM
alex committed rINP16709: Fixes INP-1797 - Speed up formatter class access from "kDBItem".
Fixes INP-1797 - Speed up formatter class access from "kDBItem"
Jul 8 2022, 9:29 AM
alex closed D396: INP-1797 - Speed up formatter class access from "kDBItem".
Jul 8 2022, 9:29 AM · Restricted Project
alex added "INP-1798" JIRA issue(s) to rINP16708: Fixes INP-1798 - Include validation errors and temp mode flag in kDBItem….
Jul 8 2022, 8:57 AM
alex committed rINP16708: Fixes INP-1798 - Include validation errors and temp mode flag in kDBItem….
Fixes INP-1798 - Include validation errors and temp mode flag in kDBItem…
Jul 8 2022, 8:57 AM
alex closed D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Jul 8 2022, 8:57 AM · Restricted Project
alex added "INP-1800" JIRA issue(s) to rINP16707: Fixes INP-1800 - Remove duplicate primary theme detection query.
Jul 8 2022, 8:56 AM
alex committed rINP16707: Fixes INP-1800 - Remove duplicate primary theme detection query.
Fixes INP-1800 - Remove duplicate primary theme detection query
Jul 8 2022, 8:56 AM
alex closed D400: INP-1800 - Remove duplicate primary theme detection query.
Jul 8 2022, 8:56 AM
alex committed rMINC16706: Fixes MINC-199 - Escape MySQL 5.7 keywords in the "modules/in….
Fixes MINC-199 - Escape MySQL 5.7 keywords in the "modules/in…
Jul 8 2022, 8:53 AM
alex added "MINC-199" JIRA issue(s) to rMINC16706: Fixes MINC-199 - Escape MySQL 5.7 keywords in the "modules/in….
Jul 8 2022, 8:53 AM
alex closed D403: MINC-199 - Escape MySQL 5.7 keywords in the "modules/in-commerce/install/install_schema.sql" file.
Jul 8 2022, 8:53 AM · Restricted Project
alex committed rINP16705: Fixes INP-1801 - Use dynamic protocol during installation.
Fixes INP-1801 - Use dynamic protocol during installation
Jul 8 2022, 8:51 AM
alex added "INP-1801" JIRA issue(s) to rINP16705: Fixes INP-1801 - Use dynamic protocol during installation.
Jul 8 2022, 8:51 AM
alex closed D404: INP-1801 - Use dynamic protocol during installation.
Jul 8 2022, 8:51 AM
alex updated the test plan for D420: INP-1817 - Change engine for storing export user presets.
Jul 8 2022, 8:43 AM
alex added "INP-1802" JIRA issue(s) to rINP16704: Fixes INP-1802 - Speed up detection of countries with states.
Jul 8 2022, 8:37 AM
alex committed rINP16704: Fixes INP-1802 - Speed up detection of countries with states.
Fixes INP-1802 - Speed up detection of countries with states
Jul 8 2022, 8:37 AM
alex closed D405: INP-1802 - Speed up detection of countries with states.
Jul 8 2022, 8:37 AM · Restricted Project
alex added "INP-1803" JIRA issue(s) to rINP16703: Fixes INP-1803 - Show non-executed SQLs during deployment.
Jul 8 2022, 8:28 AM
alex committed rINP16703: Fixes INP-1803 - Show non-executed SQLs during deployment.
Fixes INP-1803 - Show non-executed SQLs during deployment
Jul 8 2022, 8:28 AM
alex closed D406: INP-1803 - Show non-executed SQLs during deployment.
Jul 8 2022, 8:28 AM · Restricted Project
alex added "INP-1805" JIRA issue(s) to rINP16702: Fixes INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending.
Jul 8 2022, 8:24 AM
alex committed rINP16702: Fixes INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending.
Fixes INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending
Jul 8 2022, 8:24 AM
alex closed D408: INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending.
Jul 8 2022, 8:24 AM · Restricted Project
alex added "INP-1806" JIRA issue(s) to rINP16701: Fixes INP-1806 - Display output of executed MySQL commands during build script….
Jul 8 2022, 8:23 AM
alex committed rINP16701: Fixes INP-1806 - Display output of executed MySQL commands during build script….
Fixes INP-1806 - Display output of executed MySQL commands during build script…
Jul 8 2022, 8:23 AM
alex closed D409: INP-1806 - Display output of executed MySQL commands during build script execution.
Jul 8 2022, 8:22 AM · Restricted Project
alex added "INP-1807" JIRA issue(s) to rINP16700: Fixes INP-1807 - Use dedicated connection for "kLogger" class.
Jul 8 2022, 8:20 AM
alex committed rINP16700: Fixes INP-1807 - Use dedicated connection for "kLogger" class.
Fixes INP-1807 - Use dedicated connection for "kLogger" class
Jul 8 2022, 8:20 AM
alex closed D410: INP-1807 - Use dedicated connection for "kLogger" class.
Jul 8 2022, 8:20 AM
alex added "INP-1808" JIRA issue(s) to rINP16699: Fixes INP-1808 - Create "E-mail Log" records using corresponding unit.
Jul 8 2022, 7:59 AM
alex committed rINP16699: Fixes INP-1808 - Create "E-mail Log" records using corresponding unit.
Fixes INP-1808 - Create "E-mail Log" records using corresponding unit
Jul 8 2022, 7:59 AM
alex closed D412: INP-1808 - Create "E-mail Log" records using corresponding unit.
Jul 8 2022, 7:59 AM
alex retitled D412: INP-1808 - Create "E-mail Log" records using corresponding unit from INP-1808 - Create "E-mail Log" records unit corresponding unit to INP-1808 - Create "E-mail Log" records using corresponding unit.
Jul 8 2022, 7:56 AM
alex added "INP-1810" JIRA issue(s) to rINP16698: Fixes INP-1810 - Use linked info in "OnNew" event only, when it's available.
Jul 8 2022, 7:55 AM
alex committed rINP16698: Fixes INP-1810 - Use linked info in "OnNew" event only, when it's available.
Fixes INP-1810 - Use linked info in "OnNew" event only, when it's available
Jul 8 2022, 7:55 AM
alex closed D414: INP-1810 - Use linked info in "OnNew" event only, when it's available.
Jul 8 2022, 7:55 AM
alex added "MINC-196" JIRA issue(s) to rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"….
Jul 8 2022, 3:20 AM
alex committed rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"….
Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"…
Jul 8 2022, 3:20 AM
alex closed D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Jul 8 2022, 3:20 AM · Restricted Project
alex added "MINC-197" JIRA issue(s) to rMINC16696: Fixes MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Jul 8 2022, 3:18 AM
alex committed rMINC16696: Fixes MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Fixes MINC-197 - Improve user experience for "E-commerce > Sales Report" section
Jul 8 2022, 3:18 AM
alex closed D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Jul 8 2022, 3:18 AM
alex committed rMINC16695: Fixes MINC-198 - Don't use "continue" inside a "switch" statement.
Fixes MINC-198 - Don't use "continue" inside a "switch" statement
Jul 8 2022, 3:18 AM
alex added "MINC-198" JIRA issue(s) to rMINC16695: Fixes MINC-198 - Don't use "continue" inside a "switch" statement.
Jul 8 2022, 3:13 AM
alex closed D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Jul 8 2022, 3:13 AM
alex accepted D420: INP-1817 - Change engine for storing export user presets.
Jul 8 2022, 3:04 AM

Jul 6 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Added missing table creation on in-portal upgrade

Jul 6 2022, 10:45 AM
alex updated the test plan for D420: INP-1817 - Change engine for storing export user presets.
Jul 6 2022, 3:58 AM
alex requested changes to D420: INP-1817 - Change engine for storing export user presets.

The 15. Press Export button it the toolbar, confirm that "7 fields" preset exists in the "Export Preset" dropdown step fails for me with this SQL error in the export popup:

Jul 6 2022, 3:25 AM

Jul 5 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Changed install schema due Jenkins message - all primary key fields must be without null values

Jul 5 2022, 10:01 AM
erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Made all requested improvements

Jul 5 2022, 6:03 AM
alex added inline comments to D420: INP-1817 - Change engine for storing export user presets.
Jul 5 2022, 3:34 AM