Page MenuHomeIn-Portal Phabricator
Feed All Stories

Oct 3 2024

alex planned changes to D486: INP-1876 - Verify system settings access permissions before allowing to change them.
In D486#9799, @erik wrote:

Test by plan is passed, but, to have Groups section visible, with root user go to Configuration->Users-General section, press Save button - and got "Exception: Permission section not specified for prefix conf in w:\SVN\5.2.x\core\kernel\utility\event.php on line 439"

Oct 3 2024, 10:40 AM · Restricted Project
erik accepted D486: INP-1876 - Verify system settings access permissions before allowing to change them.

Test by plan is passed, but, to have Groups section visible, with root user go to Configuration->Users-General section, press Save button - and got "Exception: Permission section not specified for prefix conf in w:\SVN\5.2.x\core\kernel\utility\event.php on line 439"

Oct 3 2024, 9:53 AM · Restricted Project
alex updated the test plan for D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Oct 3 2024, 8:47 AM · Restricted Project
alex requested review of D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Oct 3 2024, 8:26 AM · Restricted Project

Aug 16 2024

alex added "INP-1725" JIRA issue(s) to rMINC16798: Bug INP-1725 - Introduce secure Session Key generation/storage.
Aug 16 2024, 3:27 AM
alex committed rMINC16798: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Aug 16 2024, 3:27 AM
alex added "INP-1725" JIRA issue(s) to rINP16797: Fixes INP-1725 - Introduce secure Session Key generation/storage.
Aug 16 2024, 3:27 AM
alex committed rINP16797: Fixes INP-1725 - Introduce secure Session Key generation/storage.
Fixes INP-1725 - Introduce secure Session Key generation/storage
Aug 16 2024, 3:27 AM

Aug 5 2024

erik accepted D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 9:38 AM · Restricted Project
erik requested changes to D480: INP-1872 - Properly handle constant absence during category cache rebuild.

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

Aug 5 2024, 9:12 AM · Restricted Project
alex added a project to D481: INP-1873 - Support MySQL 8 database collations: Restricted Project.
Aug 5 2024, 7:38 AM · Restricted Project
alex requested review of D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 7:38 AM · Restricted Project
alex added a project to D480: INP-1872 - Properly handle constant absence during category cache rebuild: Restricted Project.
Aug 5 2024, 2:35 AM · Restricted Project
alex requested review of D480: INP-1872 - Properly handle constant absence during category cache rebuild.
Aug 5 2024, 2:35 AM · Restricted Project

Aug 2 2024

alex added a child revision for D477: INP-1871 - Properly dispose session during logout workflow: Unknown Object (Differential Revision).
Aug 2 2024, 5:48 AM
alex added a child revision for D476: INP-1870 - Save the session to the database immediately after the user login: Unknown Object (Differential Revision).
Aug 2 2024, 5:48 AM

Aug 1 2024

alex added "INP-1756" JIRA issue(s) to rINP16796: [backported] Fixes INP-1756 - Create "Security*" classes for security-related….
Aug 1 2024, 3:04 AM
alex committed rINP16796: [backported] Fixes INP-1756 - Create "Security*" classes for security-related….
[backported] Fixes INP-1756 - Create "Security*" classes for security-related…
Aug 1 2024, 3:04 AM

Jul 31 2024

alex added "INP-1756" JIRA issue(s) to rINP16795: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:49 AM
alex committed rINP16795: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Fixes INP-1756 - Create "Security*" classes for security-related jobs
Jul 31 2024, 9:49 AM
alex closed D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:49 AM · Restricted Project
alex updated the test plan for D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:47 AM · Restricted Project
erik accepted D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 6:40 AM · Restricted Project
alex added a child revision for D354: INP-1756 - Create "Security*" classes for security-related jobs: D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:17 AM · Restricted Project
alex added a parent revision for D478: INP-1756 - Create "Security*" classes for security-related jobs: D354: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:17 AM · Restricted Project
alex added a project to D478: INP-1756 - Create "Security*" classes for security-related jobs: Restricted Project.
Jul 31 2024, 3:16 AM · Restricted Project
alex requested review of D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:12 AM · Restricted Project

Jul 29 2024

alex added "INP-1871" JIRA issue(s) to rINP16794: Fixes INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:57 AM
alex committed rINP16794: Fixes INP-1871 - Properly dispose session during logout workflow.
Fixes INP-1871 - Properly dispose session during logout workflow
Jul 29 2024, 9:57 AM
alex closed D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:57 AM
alex updated the test plan for D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:48 AM
erik accepted D477: INP-1871 - Properly dispose session during logout workflow.

Tested by using PHPStorm+XDebug with breakpoint in the SessionStorage::RemoveFromData method. Before patch applying SQL, that removes the priority_deleted session variable was executed. After patch applying SQL, that removes the priority_deleted session variable was not executed, because SessionSet property is set to false.

Jul 29 2024, 9:43 AM
alex updated the test plan for D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 8:24 AM
alex requested review of D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 8:24 AM
alex added "INP-1870" JIRA issue(s) to rINP16793: Fixes INP-1870 - Save the session to the database immediately after the user….
Jul 29 2024, 5:55 AM
alex committed rINP16793: Fixes INP-1870 - Save the session to the database immediately after the user….
Fixes INP-1870 - Save the session to the database immediately after the user…
Jul 29 2024, 5:55 AM
alex closed D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:55 AM
erik accepted D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:36 AM
alex updated the diff for D476: INP-1870 - Save the session to the database immediately after the user login.

Removed excessive session update statement, that happens after it's creation.

Jul 29 2024, 4:57 AM
alex updated the test plan for D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 4:54 AM
alex requested review of D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 4:50 AM

Jul 26 2024

alex committed rINP16792: Fixes INP-1869 - Add vendor autoloader support for Class Locator.
Fixes INP-1869 - Add vendor autoloader support for Class Locator
Jul 26 2024, 3:02 AM
alex added "INP-1869" JIRA issue(s) to rINP16792: Fixes INP-1869 - Add vendor autoloader support for Class Locator.
Jul 26 2024, 3:02 AM
alex closed D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 26 2024, 3:02 AM

Jul 25 2024

erik accepted D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 25 2024, 6:44 AM
alex updated the test plan for D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 25 2024, 5:05 AM
alex requested review of D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 25 2024, 4:59 AM

Jul 8 2024

alex accepted D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 8 2024, 4:56 AM

Jul 5 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:14 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:13 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:12 AM
alex requested changes to D474: MINC-202 - Fix currency selection in Site Domain scenario.

The test plan doesn't cover all add/existing code as requested in the task. For example (but there could be more scenarios), these cases aren't covered:

Jul 5 2024, 2:28 AM

Jul 4 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 4 2024, 11:16 AM

Jun 23 2024

alex added "INP-1867" JIRA issue(s) to rINP16791: Fixes INP-1867 - Remove the MySQL password warning from Phing DB dumps.
Jun 23 2024, 6:29 AM
alex committed rINP16791: Fixes INP-1867 - Remove the MySQL password warning from Phing DB dumps.
Fixes INP-1867 - Remove the MySQL password warning from Phing DB dumps
Jun 23 2024, 6:29 AM
alex closed D473: INP-1867 - Remove the MySQL password warning from Phing DB dumps.
Jun 23 2024, 6:29 AM

Jun 21 2024

erik accepted D473: INP-1867 - Remove the MySQL password warning from Phing DB dumps.

No words "mysqldump", "Warning" in the resulting files.

Jun 21 2024, 5:21 AM

Jun 20 2024

alex requested review of D473: INP-1867 - Remove the MySQL password warning from Phing DB dumps.
Jun 20 2024, 3:26 AM

Jun 17 2024

alex added "INP-1866" JIRA issue(s) to rINP16790: Fixes INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 11:30 AM
alex committed rINP16790: Fixes INP-1866 - Verify SSL certificate on cURL connections.
Fixes INP-1866 - Verify SSL certificate on cURL connections
Jun 17 2024, 11:30 AM
alex closed D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 11:30 AM
erik accepted D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 11:03 AM
alex requested review of D470: INP-1866 - Verify SSL certificate on cURL connections.

I've updated test plan (up to date SSL certificate & different SSL test domains).

Jun 17 2024, 10:55 AM
alex updated the test plan for D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 10:54 AM
alex added "INP-1864" JIRA issue(s) to rINP16789: Fixes INP-1864 - Require Username on the Login Form.
Jun 17 2024, 10:17 AM
alex committed rINP16789: Fixes INP-1864 - Require Username on the Login Form.
Fixes INP-1864 - Require Username on the Login Form
Jun 17 2024, 10:17 AM
alex closed D471: INP-1864 Require Username on the Login Form.
Jun 17 2024, 10:17 AM
alex accepted D471: INP-1864 Require Username on the Login Form.
Jun 17 2024, 10:16 AM
alex added "INP-1865" JIRA issue(s) to rINP16788: Fixes INP-1865 - Use cryptographically safe session key generator.
Jun 17 2024, 10:05 AM
alex committed rINP16788: Fixes INP-1865 - Use cryptographically safe session key generator.
Fixes INP-1865 - Use cryptographically safe session key generator
Jun 17 2024, 10:05 AM
alex closed D472: INP-1865 Use cryptographically safe session key generator.
Jun 17 2024, 10:05 AM
alex committed rMINC16787: Bug INP-1859 - Escape MySQL 8.3 keywords.
Bug INP-1859 - Escape MySQL 8.3 keywords
Jun 17 2024, 9:54 AM
alex added "INP-1859" JIRA issue(s) to rMINC16787: Bug INP-1859 - Escape MySQL 8.3 keywords.
Jun 17 2024, 9:54 AM
alex added "INP-1859" JIRA issue(s) to rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords.
Jun 17 2024, 9:53 AM
alex committed rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords.
Fixes INP-1859 - Escape MySQL 8.3 keywords
Jun 17 2024, 9:53 AM
alex closed D464: INP-1859 - Escape MySQL 8.3 keywords.
Jun 17 2024, 9:53 AM · Restricted Project
alex added "INP-1847" JIRA issue(s) to rINP16785: Fixes INP-1847 - Specify image resizing defaults for category item images.
Jun 17 2024, 9:50 AM
alex committed rINP16785: Fixes INP-1847 - Specify image resizing defaults for category item images.
Fixes INP-1847 - Specify image resizing defaults for category item images
Jun 17 2024, 9:50 AM
alex closed D453: INP-1847 - Specify image resizing defaults for category item images.
Jun 17 2024, 9:50 AM
erik requested review of D472: INP-1865 Use cryptographically safe session key generator.
Jun 17 2024, 9:14 AM
erik requested review of D471: INP-1864 Require Username on the Login Form.
Jun 17 2024, 7:42 AM
erik requested changes to D470: INP-1866 - Verify SSL certificate on cURL connections.

Last line from test result is: "Test 5 (correct custom cert failure): Failed"
Not match with defined in test plan "Test 5 (correct custom cert failure): Passed"

Jun 17 2024, 7:10 AM

Jun 14 2024

alex updated the test plan for D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 14 2024, 6:26 AM
alex requested review of D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 14 2024, 6:16 AM

Jun 6 2024

alex committed rINP16784: Fixes INP-1862 - Execute "lint" prior to deploy during the build.
Fixes INP-1862 - Execute "lint" prior to deploy during the build
Jun 6 2024, 3:00 AM
alex added "INP-1862" JIRA issue(s) to rINP16784: Fixes INP-1862 - Execute "lint" prior to deploy during the build.
Jun 6 2024, 3:00 AM
alex closed D468: INP-1862 - Execute "lint" prior to deploy during the build.
Jun 6 2024, 2:59 AM · Restricted Project

Jun 5 2024

alex added "INP-1861" JIRA issue(s) to rINP16783: Fixes INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
Jun 5 2024, 12:33 AM
alex committed rINP16783: Fixes INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
Fixes INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector
Jun 5 2024, 12:33 AM
alex closed D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
Jun 5 2024, 12:33 AM · Restricted Project

Jun 3 2024

erik accepted D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
Jun 3 2024, 11:15 AM
alex requested review of D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
In D467#9487, @erik wrote:

All right in general, but

2.6 confirm, that the design of the login page was changed - changed, but only after memcache reset
5.4 - incomplete or excessive line in test plan
5.5 confirm, that an alt attribute of the invisible link in the top left corner (on red background) has one"two three value - there is such title attribute, no alt attribute

Jun 3 2024, 11:00 AM
alex updated the test plan for D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
Jun 3 2024, 10:59 AM
alex updated the test plan for D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
Jun 3 2024, 10:57 AM

May 31 2024

erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

all right, test times:

May 31 2024, 7:13 AM · Restricted Project
alex updated the diff for D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

Indicate PHP_CodeSniffer & PHP_MessDetector versions, that support caching.

May 31 2024, 6:57 AM · Restricted Project
alex updated the test plan for D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
May 31 2024, 6:02 AM · Restricted Project
alex updated the diff for D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

Removed debug code.

May 31 2024, 5:47 AM · Restricted Project
alex updated the diff for D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

Bugfix: the PHP_MessDetector was building it's cache with absolute paths instead of a relative ones.

May 31 2024, 5:38 AM · Restricted Project
erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
May 31 2024, 5:34 AM · Restricted Project