accepted, detected difference fixed in new patch version

Disabled the EnableSystemLog setting in the Phing-generated /system/config.php.

All passed, excepting last part - config.php comparision.

Reduce scope (set of fields) for which \kDBBase::UpdateFormattersSubFields method is used to prevent accidental data loss.

In D496#10147, @erik wrote:

2 B part ir the test plan is failed. Build was not successful -

BuildException: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:84:48: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:84:48: PHPLocTask depends on PHPLoc being installed and on include_path. in /home/sites/dev/.config/composer/vendor/phing/phing/classes/phing/tasks/ext/phploc/PHPLocTask.php:189

2 B part ir the test plan is failed. Build was not successful -

New data came in during LIVE testing: the kDBItem::UpdateFormattersSubFields is used too aggressively, which results in clearing already populated date/time virtual fields. Need to adjust code/test plan for that.

In D495#10109, @erik wrote:

Error on Clean install without applying patch

On "Step 8 - Basic Configuration" first page load after previous step.

Notice (#1): Constant EDITING_MODE already defined in \home\sites\dev\web\SVN\5.2.x\core\install\step_templates\post_config.tpl on line 85

Not passed 3 E a part of the plan. Made run of php74 which phing` -f tools/build/build_all.xml build` command.
Command finished with fatal error.

Error on Clean install without applying patch

In D494#10047, @erik wrote:

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Image with typical console output is attached.

Fixed a typo (used collation instead of collection word).

1. removed support for the utf8mb4_general_ci collection, because you can't even install In-Portal with it due to the ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes error
2. rephrase invalid collation message to clearly say "what's wrong" instead of saying "what to do next"
3. added explanatory message, that tells to use utfmb3_general_ci for MySQL Server 8.x+ versions

Actualized "/system/config.php", that is created upon build.

Actualized "/system/config.php", that is created upon build.

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Can't test because of different php version on VM.

In D494#10043, @erik wrote:

No, build was not successful.

[phingcall] /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:37:41: Task exited with code 1

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:25:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:29:22: Execution of the target buildfile failed. Aborting.

Total time: 29.8418 seconds

No, build was not successful.

In D494#10041, @erik wrote:

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Non-obvious Phabricator Differential logic:

• the arc patch command svn mv SVN command (file move) as svn cp (file copy) + svn rm (file removal) commands;
• directory removal, where file move occurred, isn't marked as removed.

Same diff, but file moves in "modules/custom" folder are displayed correctly.

Included moved files, that were missing in original diff.

1. Updating D494: INP-1863 - Correct PHPUnit integration #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment. #
4. Included changes:
6. M composer.json
7. M composer.lock
8. M core/kernel/application.php
9. V core/tests/AbstractTestCase.php to: core/tests/Unit/AbstractTestCase.php
10. V core/tests/Unit/AbstractTestCase.php from: core/tests/AbstractTestCase.php
11. V core/tests/Unit/kernel/utility/formatters/kFormatterTest.php from: core/tests/kernel/utility/formatters/kFormatterTest.php
12. V core/tests/kernel/utility/formatters/kFormatterTest.php to: core/tests/Unit/kernel/utility/formatters/kFormatterTest.php

Test plan updated.

In D492#9995, @erik wrote:

Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.

Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.

All right, when debugger is off. When debugger os on - got about 20 "Trying to access array offset on value of type bool" notices

In D480#9710, @erik wrote:

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

All errors are