Page MenuHomeIn-Portal Phabricator
Feed All Stories

Dec 28 2024

alex committed rINP16475: Fixes INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.
Fixes INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS
Dec 28 2024, 6:23 AM
alex added "INP-1588" JIRA issue(s) to rINP16476: Fixes INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons.
Dec 28 2024, 6:23 AM
alex committed rINP16476: Fixes INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons.
Fixes INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons
Dec 28 2024, 6:23 AM
alex added "INP-1591" JIRA issue(s) to rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes.
Dec 28 2024, 6:23 AM
alex committed rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes.
Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes
Dec 28 2024, 6:23 AM
alex added "INP-1593" JIRA issue(s) to rINP16478: Fixes INP-1593 - Auto-detect format of provided password in "kPasswordFormatter….
Dec 28 2024, 6:23 AM
alex committed rINP16478: Fixes INP-1593 - Auto-detect format of provided password in "kPasswordFormatter….
Fixes INP-1593 - Auto-detect format of provided password in "kPasswordFormatter…
Dec 28 2024, 6:22 AM
alex added "INP-1594" JIRA issue(s) to rINP16479: Fixes INP-1594 - Generate/check category filename after page protection code….
Dec 28 2024, 6:22 AM
alex committed rINP16479: Fixes INP-1594 - Generate/check category filename after page protection code….
Fixes INP-1594 - Generate/check category filename after page protection code…
Dec 28 2024, 6:22 AM
alex added "INP-1595" JIRA issue(s) to rINP16480: Fixes INP-1595 - Allow uploading Microsoft Office 2007+ generated files in….
Dec 28 2024, 6:22 AM
alex committed rINP16480: Fixes INP-1595 - Allow uploading Microsoft Office 2007+ generated files in….
Fixes INP-1595 - Allow uploading Microsoft Office 2007+ generated files in…
Dec 28 2024, 6:22 AM
alex added "INP-1630" JIRA issue(s) to rINP16481: Fixes INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
Dec 28 2024, 6:22 AM
alex committed rINP16481: Fixes INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
Fixes INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor
Dec 28 2024, 6:22 AM
alex added "INP-1640" JIRA issue(s) to rINP16482: Fixes INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug….
Dec 28 2024, 6:22 AM
alex committed rINP16482: Fixes INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug….
Fixes INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug…
Dec 28 2024, 6:22 AM
alex added "INP-1641" JIRA issue(s) to rINP16483: Fixes INP-1641 - PHP 7 compatibility issues (5.2.x).
Dec 28 2024, 6:22 AM
alex committed rINP16483: Fixes INP-1641 - PHP 7 compatibility issues (5.2.x).
Fixes INP-1641 - PHP 7 compatibility issues (5.2.x)
Dec 28 2024, 6:22 AM
alex added "INP-1642" JIRA issue(s) to rINP16484: Fixes INP-1642 - Allow "kColumnPickerHelper" class to correctly reorder/resize….
Dec 28 2024, 6:22 AM
alex committed rINP16484: Fixes INP-1642 - Allow "kColumnPickerHelper" class to correctly reorder/resize….
Fixes INP-1642 - Allow "kColumnPickerHelper" class to correctly reorder/resize…
Dec 28 2024, 6:22 AM
alex added "INP-1577" JIRA issue(s) to rINP16513: Fixes INP-1577 - CS fix all variable type comment.
Dec 28 2024, 6:22 AM
alex committed rINP16513: Fixes INP-1577 - CS fix all variable type comment.
Fixes INP-1577 - CS fix all variable type comment
Dec 28 2024, 6:22 AM
alex added "INP-1646" JIRA issue(s) to rINP16525: Fixes INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Dec 28 2024, 6:22 AM
alex committed rINP16525: Fixes INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Fixes INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation
Dec 28 2024, 6:22 AM
alex added "INP-1643" JIRA issue(s) to rINP16526: Fixes INP-1643 - Use relative paths in "my_document" CKEditor plugin.
Dec 28 2024, 6:22 AM
alex committed rINP16526: Fixes INP-1643 - Use relative paths in "my_document" CKEditor plugin.
Fixes INP-1643 - Use relative paths in "my_document" CKEditor plugin
Dec 28 2024, 6:22 AM
alex committed rMINC16527: Fixes MINC-141 - Remove excessive "dest_country" conversion in Shipping Quotes….
Fixes MINC-141 - Remove excessive "dest_country" conversion in Shipping Quotes…
Dec 28 2024, 6:22 AM
alex added "MINC-141" JIRA issue(s) to rMINC16527: Fixes MINC-141 - Remove excessive "dest_country" conversion in Shipping Quotes….
Dec 28 2024, 6:22 AM
alex added "INP-1584" JIRA issue(s) to rINP16528: Fixes INP-1584 - Add readonly mode to "st:ContentBlock" tag.
Dec 28 2024, 6:22 AM
alex committed rINP16528: Fixes INP-1584 - Add readonly mode to "st:ContentBlock" tag.
Fixes INP-1584 - Add readonly mode to "st:ContentBlock" tag
Dec 28 2024, 6:22 AM
alex added "INP-1542" JIRA issue(s) to rINP16529: Fixes INP-1542 - Add "Export" button to "Show All" grid in "Website & Content >….
Dec 28 2024, 6:22 AM
alex committed rINP16529: Fixes INP-1542 - Add "Export" button to "Show All" grid in "Website & Content >….
Fixes INP-1542 - Add "Export" button to "Show All" grid in "Website & Content >…
Dec 28 2024, 6:22 AM
alex added "INP-1547" JIRA issue(s) to rINP16530: Fixes INP-1547 - Create "promo-block:ImageField" tag.
Dec 28 2024, 6:22 AM
alex committed rINP16530: Fixes INP-1547 - Create "promo-block:ImageField" tag.
Fixes INP-1547 - Create "promo-block:ImageField" tag
Dec 28 2024, 6:22 AM
alex added "INP-1532" JIRA issue(s) to rINP16531: Fixes INP-1532 - Allow specifying scheduled time for Promo Blocks.
Dec 28 2024, 6:21 AM
alex committed rINP16531: Fixes INP-1532 - Allow specifying scheduled time for Promo Blocks.
Fixes INP-1532 - Allow specifying scheduled time for Promo Blocks
Dec 28 2024, 6:21 AM
alex added "INP-1473" JIRA issue(s) to rINP16532: Fixes INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Dec 28 2024, 6:21 AM
alex committed rINP16532: Fixes INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Fixes INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag
Dec 28 2024, 6:21 AM
alex added "INP-1663" JIRA issue(s) to rINP16533: Fixes INP-1663 - Register missing classes in class factory V2.
Dec 28 2024, 6:21 AM
alex committed rINP16533: Fixes INP-1663 - Register missing classes in class factory V2.
Fixes INP-1663 - Register missing classes in class factory V2
Dec 28 2024, 6:21 AM
alex added "INP-1662" JIRA issue(s) to rINP16535: Fixes INP-1662 - Add methods for handling deprecations.
Dec 28 2024, 6:21 AM
alex committed rINP16535: Fixes INP-1662 - Add methods for handling deprecations.
Fixes INP-1662 - Add methods for handling deprecations
Dec 28 2024, 6:21 AM
alex added "INP-1690" JIRA issue(s) to rINP16537: [backported] Fixes INP-1690 - Remove "Intechnic\" from namespace.
Dec 28 2024, 6:21 AM
alex committed rINP16537: [backported] Fixes INP-1690 - Remove "Intechnic\" from namespace.
[backported] Fixes INP-1690 - Remove "Intechnic\" from namespace
Dec 28 2024, 6:21 AM
alex added "INP-1690" JIRA issue(s) to rINP16538: Bug INP-1690 - Remove "Intechnic\" from namespace.
Dec 28 2024, 6:21 AM
alex committed rINP16538: Bug INP-1690 - Remove "Intechnic\" from namespace.
Bug INP-1690 - Remove "Intechnic\" from namespace
Dec 28 2024, 6:21 AM
alex added "INP-1566" JIRA issue(s) to rINP16544: Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log.
Dec 28 2024, 6:21 AM
alex committed rINP16544: Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log.
Fixes INP-1566 - Don't log errors from 3rd party libraries to System Log
Dec 28 2024, 6:21 AM
alex committed rINP16771: Fixes INP-1836 - Don't serialize "SecurityEncrypter" class properties.
Fixes fINP-1836 - Don't serialize "SecurityEncrypter" class properties
Dec 28 2024, 6:21 AM
alex added "INP-1001" JIRA issue(s) to rMINN15245: Bug #0001226: Storing function "crc32" results in database problem.
Dec 28 2024, 12:34 AM
alex committed rMINN15245: Bug #0001226: Storing function "crc32" results in database problem.
Bug #0001226: Storing function "crc32" results in database problem
Dec 28 2024, 12:34 AM
alex added "INP-1001" JIRA issue(s) to rMINC15244: Bug #0001226: Storing function "crc32" results in database problem.
Dec 28 2024, 12:34 AM
alex committed rMINC15244: Bug #0001226: Storing function "crc32" results in database problem.
Bug #0001226: Storing function "crc32" results in database problem
Dec 28 2024, 12:34 AM
alex added "INP-1001" JIRA issue(s) to rINP15246: Fixes #0001226: Storing function "crc32" results in database problem.
Dec 28 2024, 12:32 AM
alex committed rINP15246: Fixes #0001226: Storing function "crc32" results in database problem.
Fixes #0001226: Storing function "crc32" results in database problem
Dec 28 2024, 12:32 AM

Dec 23 2024

erik accepted D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 23 2024, 6:04 AM
alex updated the test plan for D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 23 2024, 6:01 AM

Dec 21 2024

alex updated the test plan for D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 21 2024, 9:02 AM
alex updated the test plan for D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 21 2024, 8:59 AM
alex updated the diff for D502: INP-1891 - Display PHP errors in the Phing build log.

Corrected phrasing.

Dec 21 2024, 8:56 AM

Dec 20 2024

alex updated the diff for D502: INP-1891 - Display PHP errors in the Phing build log.

Removed debug code from test plan execution attempt.

Dec 20 2024, 2:59 PM
alex requested review of D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 20 2024, 2:56 PM

Dec 19 2024

erik added a comment to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

Error fixed after svn update and clear memory cache.

Dec 19 2024, 12:48 PM
erik accepted D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Dec 19 2024, 12:42 PM
erik added a comment to D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Yes, when restarting before open index.php, then all is ok - no delay after patch applied

Dec 19 2024, 12:01 PM
erik accepted D491: INP-1880 - Fix notice on missing event permission mapping.
Dec 19 2024, 11:51 AM · Restricted Project
alex added a comment to D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.
In D501#10225, @erik wrote:

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

Dec 19 2024, 11:44 AM
erik accepted D498: INP-1887 - Don't define the "EDITING_MODE" constant in the Installation Wizard.
Dec 19 2024, 11:34 AM
erik accepted D499: INP-1888 - Detect Memcache availability during installation using Memcache/Memcached PHP modules.
Dec 19 2024, 11:24 AM
erik requested changes to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

There happens error, due to this line in the AbstractBrowserTestCase.php

Dec 19 2024, 10:52 AM
erik accepted D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

Dec 19 2024, 10:25 AM

Dec 11 2024

alex added a comment to D497: INP-1886 - Add value-clearing support for "kDateFormatter::UpdateSubFields" method.
In D497#10220, @erik wrote:

maybe, test plan should include requirement to have checked "Use Cron to run Scheduled Tasks" - otherwise visible email queue is usually empty.

Dec 11 2024, 6:01 AM · Restricted Project
alex updated the test plan for D497: INP-1886 - Add value-clearing support for "kDateFormatter::UpdateSubFields" method.
Dec 11 2024, 5:31 AM · Restricted Project

Dec 10 2024

erik accepted D497: INP-1886 - Add value-clearing support for "kDateFormatter::UpdateSubFields" method.

All tests passed.

Dec 10 2024, 10:55 AM · Restricted Project
alex updated the test plan for D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.
Dec 10 2024, 7:56 AM
alex requested review of D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.
Dec 10 2024, 7:56 AM

Nov 30 2024

alex added "INP-1863" JIRA issue(s) to rMCUS16823: Bug INP-1863 - Correct PHPUnit integration.
Nov 30 2024, 12:56 PM
alex committed rMCUS16823: Bug INP-1863 - Correct PHPUnit integration.
Bug INP-1863 - Correct PHPUnit integration
Nov 30 2024, 12:56 PM
alex committed rINP16822: Fixes INP-1863 - Correct PHPUnit integration.
Fixes INP-1863 - Correct PHPUnit integration
Nov 30 2024, 12:56 PM
alex added "INP-1863" JIRA issue(s) to rINP16822: Fixes INP-1863 - Correct PHPUnit integration.
Nov 30 2024, 12:56 PM
alex closed D494: INP-1863 - Correct PHPUnit integration.
Nov 30 2024, 12:56 PM

Nov 29 2024

alex added a comment to D494: INP-1863 - Correct PHPUnit integration.
In D494#10203, @erik wrote:

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:216:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:235:46: Task exited with code 2

Total time: 31.6997 seconds

At selenium window also some errors displayed -

Nov 29 2024, 5:42 AM
erik accepted D494: INP-1863 - Correct PHPUnit integration.

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

Nov 29 2024, 4:36 AM

Nov 27 2024

alex updated the test plan for D494: INP-1863 - Correct PHPUnit integration.
Nov 27 2024, 7:52 AM
alex requested review of D494: INP-1863 - Correct PHPUnit integration.
Nov 27 2024, 7:40 AM
alex added a comment to D494: INP-1863 - Correct PHPUnit integration.
In D494#10195, @erik wrote:

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:192:6: /home/sites/ dev/web/SVN/5.2.x/tools/build/targets/common.xml:205:46: Task exited with code 2

Total time: 6 minutes 42.55 seconds

Nov 27 2024, 7:40 AM
erik requested changes to D494: INP-1863 - Correct PHPUnit integration.

Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

Nov 27 2024, 5:45 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit
Nov 27 2024, 5:11 AM

Nov 26 2024

alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.

Removed debug code, that added from test plan.

Nov 26 2024, 12:01 PM
alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.

Speed up code coverage collection 4.25x times by not building coverage report for files, that weren't executed in tests.

Nov 26 2024, 2:54 AM

Nov 25 2024

alex requested review of D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Nov 25 2024, 10:19 AM
alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.
  1. fixed sh: ${phpunit.testsuite}: bad substitution error
  2. use proper php binary for executing PHPUnit
Nov 25 2024, 6:36 AM
alex updated the test plan for D494: INP-1863 - Correct PHPUnit integration.
Nov 25 2024, 6:00 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Partialy tested, build failed after "run the phing -f tools/build/build_all.xml phpunit command" in the part 4 of test plan

Nov 25 2024, 5:34 AM

Nov 22 2024

alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.

Rebasing.

Nov 22 2024, 5:03 AM
alex added "INP-1885" JIRA issue(s) to rINP16821: Fixes INP-1885 - Consistently use PHP binary during the Build.
Nov 22 2024, 4:58 AM
alex committed rINP16821: Fixes INP-1885 - Consistently use PHP binary during the Build.
Fixes INP-1885 - Consistently use PHP binary during the Build
Nov 22 2024, 4:58 AM
alex closed D496: INP-1885 - Consistently use PHP binary during the Build.
Nov 22 2024, 4:58 AM
alex added "INP-1884" JIRA issue(s) to rINP16820: Fixes INP-1884 - Actualize "/system/config.php" created during the build.
Nov 22 2024, 4:56 AM
alex committed rINP16820: Fixes INP-1884 - Actualize "/system/config.php" created during the build.
Fixes INP-1884 - Actualize "/system/config.php" created during the build
Nov 22 2024, 4:56 AM
alex closed D495: INP-1884 - Actualize "/system/config.php" created during the build.
Nov 22 2024, 4:56 AM