Page MenuHomeIn-Portal Phabricator

INP-1502 - Gracefully handle case of missing file/line keys in stack trace info

Authored by alex on Nov 17 2016, 4:03 PM.


Test Plan
  1. in IDE:
    • open /core/units/phrases/phrases_config.php file for editing
    • change value of ListSQLs unit config option to introduce SQL syntax error
  2. in Admin Console
    • go to Logs & ReportsSystem Log section
    • press Delete All to remove all logged records
    • go to Website & ContentLabels & Phrases section
    • confirm, that SQL error happens
    • confirm, that in Debugger (when debugger is enabled) the only error is one about broken SQL and it has trace above it
    • go to Logs & ReportsSystem Log section
    • confirm, that only present record is one about SQL error

Diff Detail

rINP In-Portal
Lint ErrorsExcuse: Maybe will fix in 5.3.x.
No Unit Test Coverage
Build Status
Buildable 529
Build 529: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 616.Nov 17 2016, 4:03 PM
alex retitled this revision from to INP-1502 - Gracefully handle case of missing file/line keys in stack trace info.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1502.
erik accepted this revision.Nov 22 2016, 5:39 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 5:39 AM
This revision was automatically updated to reflect the committed changes.