Page MenuHomeIn-Portal Phabricator
Differential D318

INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
ClosedPublic
Actions

Authored by alex on Jul 8 2017, 1:12 PM.

Details

Reviewers
erik
Commits
rINP16610: Fixes INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINC16612: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINB16611: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINL16613: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINN16614: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
Test Plan
  • in PhpStorm:
    1. search for no_html_escape attribute usage
    2. confirm, that none is found
  • in Web Browser:
    1. go to Admin Console
    2. try using Catalog (going into sub-category and back, adding/editing/deleting category)
    3. try adding/editing a user
    4. confirm, that above actions were completed successfully

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jul 8 2017, 1:12 PM
alex edited the test plan for this revision. (Show Details)Jul 9 2017, 3:46 AM
erik accepted this revision.Jul 12 2017, 6:05 AM
This revision is now accepted and ready to land.Jul 12 2017, 6:05 AM
Closed by commit rINP16610: Fixes INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag (authored by alex). · Explain WhyApr 6 2018, 8:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 175816551Jul 8 2017, 1:12 PM
★
★
Diff 283316603rINP16610Apr 6 2018, 8:39 AM
★
★

Diff 833

View Options

branches/5.2.x/core/admin_templates/catalog/catalog_counters.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/catalog_tab.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/categories/category_path.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/categories/permissions_tab.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/config/config_edit.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/config/config_general.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/config/config_search.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/config/config_search_edit.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/config/config_universal.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/custom_fields/custom_fields_edit.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/custom_fields/custom_fields_list.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/export/export_progress.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/head.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/import/import_start.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/promo_block_groups/promo_block_group_list.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/reviews/review_direct_edit.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/reviews/reviews_tab.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/submissions/submission_edit_logs.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/submissions/submission_log_edit.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/submissions/submission_view.tpl

Loading...
View Options

branches/5.2.x/core/admin_templates/submissions/submissions_list.tpl

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server