INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
ClosedPublic
Actions

Authored by alex on Jul 8 2017, 1:12 PM.

Details

Reviewers

Commits

rINP16610: Fixes INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINC16612: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINB16611: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINL16613: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
rMINN16614: Bug INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag

Test Plan

in PhpStorm:
1. search for no_html_escape attribute usage
2. confirm, that none is found
in Web Browser:
1. go to Admin Console
2. try using Catalog (going into sub-category and back, adding/editing/deleting category)
3. try adding/editing a user
4. confirm, that above actions were completed successfully

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 750
Build 750: arc lint + arc unit

Event Timeline

alex created this revision.Jul 8 2017, 1:12 PM

Herald added a reviewer: erik. · View Herald TranscriptJul 8 2017, 1:12 PM

alex edited the test plan for this revision. (Show Details)Jul 9 2017, 3:46 AM

erik accepted this revision.Jul 12 2017, 6:05 AM

This revision is now accepted and ready to land.Jul 12 2017, 6:05 AM

Closed by commit rINP16610: Fixes INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag (authored by alex). · Explain WhyApr 6 2018, 8:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	758	16551		Jul 8 2017, 1:12 PM	★	★
Diff 2	833	16603	rINP16610	Apr 6 2018, 8:39 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 758

View Options

core/admin_templates/catalog/catalog_counters.tpl

View Options

core/admin_templates/catalog_tab.tpl

View Options

core/admin_templates/categories/category_path.tpl

View Options

core/admin_templates/categories/permissions_tab.tpl

View Options

core/admin_templates/config/config_edit.tpl

View Options

core/admin_templates/config/config_general.tpl

View Options

core/admin_templates/config/config_search.tpl

View Options

core/admin_templates/config/config_search_edit.tpl

View Options

core/admin_templates/config/config_universal.tpl

View Options

core/admin_templates/custom_fields/custom_fields_edit.tpl

View Options

core/admin_templates/custom_fields/custom_fields_list.tpl

View Options

core/admin_templates/export/export_progress.tpl

View Options

core/admin_templates/head.tpl

View Options

core/admin_templates/import/import_start.tpl

View Options

core/admin_templates/promo_block_groups/promo_block_group_list.tpl

View Options

core/admin_templates/reviews/review_direct_edit.tpl

View Options

core/admin_templates/reviews/reviews_tab.tpl

View Options

core/admin_templates/submissions/submission_edit_logs.tpl

View Options

core/admin_templates/submissions/submission_log_edit.tpl

View Options

core/admin_templates/submissions/submission_view.tpl

View Options

core/admin_templates/submissions/submissions_list.tpl

View Options

modules/in-bulletin/admin_templates/catalog_tab.tpl

View Options

modules/in-bulletin/admin_templates/user_item_tab.tpl

View Options

modules/in-commerce/admin_templates/catalog_tab.tpl

View Options

modules/in-commerce/admin_templates/payment_type/payment_type_gateway.tpl

View Options

modules/in-commerce/admin_templates/products/products_pricing_grid.tpl

View Options

modules/in-commerce/admin_templates/user_item_tab.tpl

View Options

modules/in-commerce/admin_templates/user_order_item_tab.tpl

View Options

modules/in-link/admin_templates/catalog_tab.tpl

View Options

modules/in-link/admin_templates/duplicate_checker.tpl

View Options

modules/in-link/admin_templates/user_item_tab.tpl

View Options

modules/in-news/admin_templates/catalog_tab.tpl

View Options

modules/in-news/admin_templates/user_item_tab.tpl

			Path	Packages
M			core/admin_templates/catalog/catalog_counters.tpl (2 lines)
M			core/admin_templates/catalog_tab.tpl (2 lines)
M			core/admin_templates/categories/category_path.tpl (2 lines)
M			core/admin_templates/categories/permissions_tab.tpl (4 lines)
M			core/admin_templates/config/config_edit.tpl (2 lines)
M			core/admin_templates/config/config_general.tpl (2 lines)
M			core/admin_templates/config/config_search.tpl (2 lines)
M			core/admin_templates/config/config_search_edit.tpl (2 lines)
M			core/admin_templates/config/config_universal.tpl (2 lines)
M			core/admin_templates/custom_fields/custom_fields_edit.tpl (2 lines)
M			core/admin_templates/custom_fields/custom_fields_list.tpl (2 lines)
M			core/admin_templates/export/export_progress.tpl (2 lines)
M			core/admin_templates/head.tpl (2 lines)
M			core/admin_templates/import/import_start.tpl (2 lines)
M			core/admin_templates/promo_block_groups/promo_block_group_list.tpl (2 lines)
M			core/admin_templates/reviews/review_direct_edit.tpl (2 lines)
M			core/admin_templates/reviews/reviews_tab.tpl (2 lines)
M			core/admin_templates/submissions/submission_edit_logs.tpl (2 lines)
M			core/admin_templates/submissions/submission_log_edit.tpl (2 lines)
M			core/admin_templates/submissions/submission_view.tpl (2 lines)
M			core/admin_templates/submissions/submissions_list.tpl (2 lines)
M			modules/in-bulletin/admin_templates/catalog_tab.tpl (2 lines)
M			modules/in-bulletin/admin_templates/user_item_tab.tpl (2 lines)
M			modules/in-commerce/admin_templates/catalog_tab.tpl (2 lines)
M			modules/in-commerce/admin_templates/payment_type/payment_type_gateway.tpl (4 lines)
M			modules/in-commerce/admin_templates/products/products_pricing_grid.tpl (4 lines)
M			modules/in-commerce/admin_templates/user_item_tab.tpl (2 lines)
M			modules/in-commerce/admin_templates/user_order_item_tab.tpl (2 lines)
M			modules/in-link/admin_templates/catalog_tab.tpl (2 lines)
M			modules/in-link/admin_templates/duplicate_checker.tpl (2 lines)
M			modules/in-link/admin_templates/user_item_tab.tpl (2 lines)
M			modules/in-news/admin_templates/catalog_tab.tpl (2 lines)
M			modules/in-news/admin_templates/user_item_tab.tpl (2 lines)

INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tagClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 758

core/admin_templates/catalog/catalog_counters.tpl

core/admin_templates/catalog_tab.tpl

core/admin_templates/categories/category_path.tpl

core/admin_templates/categories/permissions_tab.tpl

core/admin_templates/config/config_edit.tpl

core/admin_templates/config/config_general.tpl

core/admin_templates/config/config_search.tpl

core/admin_templates/config/config_search_edit.tpl

core/admin_templates/config/config_universal.tpl

core/admin_templates/custom_fields/custom_fields_edit.tpl

core/admin_templates/custom_fields/custom_fields_list.tpl

core/admin_templates/export/export_progress.tpl

core/admin_templates/head.tpl

core/admin_templates/import/import_start.tpl

core/admin_templates/promo_block_groups/promo_block_group_list.tpl

core/admin_templates/reviews/review_direct_edit.tpl

core/admin_templates/reviews/reviews_tab.tpl

core/admin_templates/submissions/submission_edit_logs.tpl

core/admin_templates/submissions/submission_log_edit.tpl

core/admin_templates/submissions/submission_view.tpl

core/admin_templates/submissions/submissions_list.tpl

modules/in-bulletin/admin_templates/catalog_tab.tpl

modules/in-bulletin/admin_templates/user_item_tab.tpl

modules/in-commerce/admin_templates/catalog_tab.tpl

modules/in-commerce/admin_templates/payment_type/payment_type_gateway.tpl

modules/in-commerce/admin_templates/products/products_pricing_grid.tpl

modules/in-commerce/admin_templates/user_item_tab.tpl

modules/in-commerce/admin_templates/user_order_item_tab.tpl

modules/in-link/admin_templates/catalog_tab.tpl

modules/in-link/admin_templates/duplicate_checker.tpl

modules/in-link/admin_templates/user_item_tab.tpl

modules/in-news/admin_templates/catalog_tab.tpl

modules/in-news/admin_templates/user_item_tab.tpl

INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag
ClosedPublic
Actions

Revision Contents
Changeset List