Page MenuHomeIn-Portal Phabricator

INP-1732 Create user session, when search is performed

Authored by glebs on Feb 6 2018, 9:55 AM.


Test Plan
NOTE: Use advanced theme for testing.
  1. Go to frontend and perform a search
  2. In any mysql client (phpmyadmin or PhpStorm) check Search table (e.g. "inp_ses_932492397_inp_Search") is created
  3. In any mysql client (phpmyadmin or PhpStorm) run SQL to expire session like
UPDATE UserSessions SET LastAccessed = 0 WHERE SessionKey = 932492397

Where 932492397 - number from search table name

  1. Go to admin ConfigurationWebsiteScheduled Task
  2. Check delete_expired_sessions task and click on Run button in toolbar
  3. In any mysql client (phpMyAdmin or PhpStorm) confirm temp Search table dropped

Diff Detail

rINP In-Portal
Lint ErrorsExcuse: Looks ok
No Unit Test Coverage
Build Status
Buildable 826
Build 826: arc lint + arc unit

Event Timeline

glebs created this revision.Feb 6 2018, 9:55 AM
alex requested changes to this revision.Feb 6 2018, 10:05 AM

Sorry, don't know how to test by user

The problem described in Confluence discussion from connected JIRA task is that session isn't created, when search is performed by guest and therefore search tables created are never are deleted by session expiration script. According to that you need to test, that prior to this change no sessions are created, but after patch is applied sessions are created AND search tables gets removed by session expiration code.

This revision now requires changes to proceed.Feb 6 2018, 10:05 AM
glebs requested review of this revision.Feb 7 2018, 6:39 AM
glebs edited the test plan for this revision. (Show Details)
glebs edited edge metadata.
alex edited the test plan for this revision. (Show Details)Feb 7 2018, 8:13 AM
alex edited reviewers, added: erik; removed: alex.
erik accepted this revision.Feb 8 2018, 5:28 AM
This revision is now accepted and ready to land.Feb 8 2018, 5:28 AM
This revision was automatically updated to reflect the committed changes.