Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/admin_templates/incs/cms.cssthemes/advanced/platform/inc/styles.css

INP-1738 - Apply CKEditor style changes in portable form
Needs RevisionPublic

Authored by alex on Apr 17 2018, 3:55 AM.


Test Plan

Same as for D274.

Diff Detail

rINP In-Portal
No Linters Available
No Unit Test Coverage
Build Status
Buildable 867
Build 867: arc lint + arc unit

Event Timeline

alex created this revision.Apr 17 2018, 3:55 AM
alex added a project: Restricted Project.Apr 18 2018, 5:36 AM
erik edited edge metadata.Apr 30 2018, 6:07 AM

Testing in progress, not finished. Cant normally upgrade from 5.1.c to 5.2.x. -

Patching to 5.2.2-B2 version:

Hunk #1 FAILED at 801.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/skin_css_8ikYD3.rej

Also much of SQL errors (trying write to the unexisting SystemLog table) during upgrate dfrom 5.1.x to 5.2.x.

alex added a comment.Apr 30 2018, 7:28 AM

After discussing with reviewer figured out, that test plan needs to be changed to test, that correct Styles dropdown works in all themes and not advanced theme only.

erik requested changes to this revision.May 2 2018, 5:36 AM

Tested - this change does not affect CKEditor style dropdown in the other themes (default, simple). While testing, cms.css was changed to have width 300px. In the advanced theme dropdown become about square (300x300), and dropdowns in the other themes (default, simple) has no changes.

This revision now requires changes to proceed.May 2 2018, 5:36 AM