Page MenuHomeIn-Portal Phabricator

INP-1741 - Vertically align grid icons
ClosedPublic

Authored by alex on Apr 19 2018, 4:42 AM.

Details

Test Plan
  1. store icon below in core/admin_templates/img/itemicons/icon16_square.png location:
  2. open core/units/languages/languages_config.php for editing in IDE
  3. replace all icon16_*.png images with icon16_square.png
  4. save changes
  5. login to Admin Console
  6. go to ConfigurationWebsiteRegional section
  7. confirm, that:
    • checkboxes are vertically centered in their rows
    • images after checkboxes (black square with red border) are vertically centered in their rows

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Apr 19 2018, 4:42 AM
alex added a project: Restricted Project.Apr 19 2018, 4:43 AM
erik accepted this revision.Apr 19 2018, 5:50 AM
This revision is now accepted and ready to land.Apr 19 2018, 5:50 AM
alex planned changes to this revision.Apr 20 2018, 2:45 AM

In Firefox checkbox table cell height is slightly larger (by 0.23 px) then data row height resulting in visible vertical checkbox column offset for grids with 10+ rows. Needs to be addressed via CSS somehow.

alex updated this revision to Diff 881.Nov 9 2018, 4:06 AM

Fixed Firefox icon alignment issues on large (>10 rows) grids

This revision is now accepted and ready to land.Nov 9 2018, 4:06 AM
alex requested review of this revision.Nov 9 2018, 4:07 AM
alex edited edge metadata.
erik requested changes to this revision.Nov 12 2018, 5:01 AM
  1. I do not understand where is improvement. I see, that before icon was 1 pixel over checkox. Now it is 1 pixel under checkbox, and I do not see any issue related to row count in "before" case

Maybe, right test plan writing may help this situation.

  1. When testing, I tried to add more rows to "Regional" grid, and, after 5-6 rows added by standard in-portal grid interface, i got errors.
This revision now requires changes to proceed.Nov 12 2018, 5:01 AM
alex edited the test plan for this revision. (Show Details)Nov 12 2018, 5:54 AM
alex requested review of this revision.Nov 12 2018, 5:58 AM
alex edited edge metadata.

This must be perception issue with that specific icon and fact, that it has own transparent margins that aren't aligned. Below I've attached 2 images to demonstrate the issue:

  • broken:
  • fixed:

I've also updated the test plan use same black square image for which you can clearly see centering issue.

alex added a comment.Nov 12 2018, 6:01 AM
In D340#7001, @erik wrote:
  1. When testing, I tried to add more rows to "Regional" grid, and, after 5-6 rows added by standard in-portal grid interface, i got errors.

@erik , please report this separate as a bug in the Confluence. Maybe it already was reported.

erik accepted this revision.Nov 14 2018, 4:14 AM
This revision is now accepted and ready to land.Nov 14 2018, 4:14 AM
This revision was automatically updated to reflect the committed changes.