Page MenuHomeIn-Portal Phabricator

INP-1745 Connect "Modified" and "ModifiedById" fields to Links
ClosedPublic

Authored by erik on May 15 2018, 10:43 AM.

Details

Summary

"Modified" and "ModifiedById" fields connected to category item units.

Test Plan

Topics

  1. create new user in the adm.console
  2. login with newly created user to front-end
  3. click on the "Forums" link in the top menu
  4. click on the "New Topic" link in the sidebar's "Action Box" section
  5. fill all required fields
  6. submit form (click "Create" button)
  7. go to adm console
  8. click on the "Topics" section
  9. confirm that just entered topic is visible in the grid, including "Modified On" and "Modified By" columns
  10. double click just entered topic in the grid to edit it
  11. confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
  12. confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field

Links

  1. click on the "Links" section
  2. click on the "New Link" button in the toolbar
  3. fill all required fields
  4. confirm, that Modified and Modified By fields aren't shown on the form
  5. submit form (click "Save" button)
  6. confirm that just entered link is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
  7. double click just entered link in the grid to edit it
  8. change some link field value
  9. submit form (click "Save" button)
  10. confirm that just modified link have non-empty values in the "Modified On" and "Modified By" columns
  11. double click just entered link in the grid to edit it
  12. confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
  13. confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field

Products

  1. click on the "Products" section
  2. click on the "New Product" button in the toolbar
  3. fill all required fields
  4. confirm, that Modified and Modified By fields aren't shown on the form
  5. submit form (click "Save" button)
  6. confirm that just entered product is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
  7. double click just entered product in the grid to edit it
  8. change some product field value
  9. submit form (click "Save" button)
  10. confirm that just modified product have non-empty values in the "Modified On" and "Modified By" columns
  11. double click just entered product in the grid to edit it
  12. confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
  13. confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field

Articles

  1. click on the "Articles" section
  2. click on the "New Article" button in the toolbar
  3. fill all required fields
  4. confirm, that Modified and Modified By fields aren't shown on the form
  5. submit form (click "Save" button)
  6. confirm that just entered article is visible in the grid, including "Modified On" and "Modified By" columns, that have empty and "n/a" values respectively
  7. double click just entered article in the grid to edit it
  8. change some article field value
  9. submit form (click "Save" button)
  10. confirm that just modified article have non-empty values in the "Modified On" and "Modified By" columns
  11. double click just entered article in the grid to edit it
  12. confirm that "Modified" label with datetime value, same as in the grid, is visible under "Created On" field
  13. confirm that "Modified By" label with username value, same as in the grid, is visible under "Modified" field

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Full files re-formatting is not part of this task.
SeverityLocationCodeMessage
Errormodules/in-bulletin/units/topics/topics_config.php:312PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:312PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:339PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:339PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:339PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:339PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:341PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:341PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:341PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:341PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:358PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:358PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:358PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:358PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:360PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:360PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-bulletin/units/topics/topics_config.php:360PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:360PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-bulletin/units/topics/topics_config.php:478PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/topics/topics_config.php:478PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/topics/topics_config.php:480PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/topics/topics_config.php:480PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/topics/topics_config.php:546PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/topics/topics_config.php:546PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.AfterCodingStandard.WhiteSpace.CommaSpacing.After
Errormodules/in-bulletin/units/topics/topics_config.php:546PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 879
Build 879: arc lint + arc unit

Event Timeline

erik created this revision.May 15 2018, 10:43 AM
erik updated this revision to Diff 859.May 15 2018, 10:50 AM
  1. Fixed phrase module.
  2. Fixed CS errors.
alex requested changes to this revision.May 15 2018, 11:45 AM

Please also separate test plan into smaller fragments to ease testing. One test plan per each In-Portal module would be great.

modules/in-bulletin/admin_templates/topics/topics_edit.tpl
81
  1. move field into IF statement, added below
  2. show field value using inp_label

there is no point in allowing user to enter Modified field value, because it will be replaced by changed code

This revision now requires changes to proceed.May 15 2018, 11:45 AM
erik edited the test plan for this revision. (Show Details)May 16 2018, 7:08 AM
erik edited the test plan for this revision. (Show Details)
erik edited the test plan for this revision. (Show Details)
erik updated this revision to Diff 860.May 16 2018, 7:13 AM
erik edited edge metadata.

Changed "Modified" output on topic edit form.

alex requested changes to this revision.May 16 2018, 7:59 AM
alex added inline comments.
modules/in-bulletin/admin_templates/topics/topics_edit.tpl
84
NOTE: Repeat with similar fields in other affected units (covered by this Differential Revision only).
  1. Replace with:
<inp2:m_RenderElement name="inp_label" prefix="bb" field="ModifiedBy"/>
  1. Update test plan to check for same value being shown in grid and during editing.

I have Front-End user with both Username and Email fields entered. In grid I'm seeing value of Username field (correct), but during editing I'm setting value of Email field.

This revision now requires changes to proceed.May 16 2018, 7:59 AM
erik edited the test plan for this revision. (Show Details)May 16 2018, 8:26 AM
erik updated this revision to Diff 861.May 16 2018, 8:30 AM
erik edited edge metadata.
erik edited the test plan for this revision. (Show Details)

Made "Modified By" username output in place of e-mail in the edit forms.

alex edited the test plan for this revision. (Show Details)May 16 2018, 8:48 AM
alex accepted this revision.May 16 2018, 9:09 AM
alex edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.May 16 2018, 9:10 AM
This revision was landed with ongoing or failed builds.Mar 12 2021, 10:30 AM
This revision was automatically updated to reflect the committed changes.