Page MenuHomeIn-Portal Phabricator

INP-1749 - Load all content blocks of a page with a single database query
ClosedPublic

Authored by alex on Sep 19 2018, 4:52 AM.

Details

Test Plan
  1. don't apply patch yet
  2. in IDE on the index.tpl of your theme add multiple content blocks with some sample content
  3. open homepage on Front-End (not via Admin Console frame)
  4. confirm, that:
    • entered content is displayed
    • there is a separate SQL statement for loading each of the content blocks
  5. apply the patch
  6. reload hompeage
  7. confirm, that:
    • entered content is displayed
    • there is a single SQL statement per page for loading all of the content blocks from given page

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 884
Build 884: arc lint + arc unit

Event Timeline

alex created this revision.Sep 19 2018, 4:52 AM
alex added a project: Restricted Project.Sep 19 2018, 4:52 AM
erik accepted this revision.Sep 19 2018, 5:46 AM
This revision is now accepted and ready to land.Sep 19 2018, 5:46 AM
This revision was automatically updated to reflect the committed changes.