Page MenuHomeIn-Portal Phabricator

MINC-195 Don't use "break" during shipping quote aggregation

Authored by erik on Oct 24 2018, 11:06 AM.


Test Plan
NOTE: Perform tests on PHP 7+.

Test Plan (part 1)

  1. in the /index.php file add $application->recallObject('ShippingQuoteCollector'); after $application->Init();
  2. open home page, that is using just changed index.php
  3. confirm that no fatal error happens

Test Plan (part 2)

  1. login to the Administrative Console
  2. create 2+ custom shipping types
  3. create product, that allow use only one of created shipping types via shipping limitations
  4. start creating order
  5. confirm that on the Shipping tab only one shipping type is available

Diff Detail

rINP In-Portal
Lint ErrorsExcuse: Full file re-formatting is not part of this task.
No Unit Test Coverage
Build Status
Buildable 888
Build 888: arc lint + arc unit

Event Timeline

erik created this revision.Oct 24 2018, 11:06 AM
alex requested changes to this revision.Oct 26 2018, 4:21 AM

You're only testing new code, but existing code isn't tested. The test plan should also cover, that shipping limitations are applied correctly.


move that check outside of the method

This revision now requires changes to proceed.Oct 26 2018, 4:21 AM
erik edited the test plan for this revision. (Show Details)Oct 29 2018, 6:08 AM
erik updated this revision to Diff 873.Oct 29 2018, 6:13 AM
erik edited edge metadata.

Condition moved one level up.

alex edited the summary of this revision. (Show Details)Nov 1 2018, 3:40 AM
alex edited the test plan for this revision. (Show Details)
alex added a project: Restricted Project.
alex edited the test plan for this revision. (Show Details)Nov 1 2018, 3:53 AM
alex accepted this revision.Nov 1 2018, 4:06 AM
This revision is now accepted and ready to land.Nov 1 2018, 4:06 AM
This revision was landed with ongoing or failed builds.Dec 11 2020, 3:22 AM
This revision was automatically updated to reflect the committed changes.