Page MenuHomeIn-Portal Phabricator
Differential D366

INP-1769 - Truncate search result table instead of dropping it
ClosedPublic
Actions

Authored by alex on May 30 2019, 8:08 AM.

Details

Reviewers
erik
Commits
rINP16655: Fixes INP-1769 - Truncate search result table instead of dropping it
Test Plan
  • in Admin Console
    1. enter some data for Categories/Sections and Links
  • on Front-End
    1. perform search
    2. confirm, that, depending on a search keyword:
      • data from both Categories/Sections and Links is found
      • data from only Categories/Sections is found
      • data from only Links is found
      • no data is found
      • nice looking error is displayed, when keyword was too short

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing, because it will mask useful changes.
SeverityLocationCodeMessage
Errorcore/kernel/db/cat_event_handler.php:1354PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/kernel/db/cat_event_handler.php:1354PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/kernel/db/cat_event_handler.php:1355PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1355PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1355PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1355PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1357PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/db/cat_event_handler.php:1357PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/kernel/db/cat_event_handler.php:1359PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1359PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1369PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1369PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1369PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1369PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1654PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1654PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1654PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1654PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1656PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/db/cat_event_handler.php:1656PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/kernel/db/cat_event_handler.php:1657PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1657PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errorcore/kernel/db/cat_event_handler.php:1658PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1658PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errorcore/kernel/db/cat_event_handler.php:1658PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Unit
No Unit Test Coverage
Build Status
Buildable 929
Build 929: arc lint + arc unit

Event Timeline

alex created this revision.May 30 2019, 8:08 AM
alex requested review of this revision.May 30 2019, 8:08 AM
alex added a project: Restricted Project.May 30 2019, 8:09 AM
erik accepted this revision.May 31 2019, 5:56 AM
This revision is now accepted and ready to land.May 31 2019, 5:56 AM
This revision was landed with ongoing or failed builds.Jan 4 2021, 2:48 AM
Closed by commit rINP16655: Fixes INP-1769 - Truncate search result table instead of dropping it (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 190616637May 30 2019, 8:08 AM
★
★
Diff 296516654rINP16655Jan 4 2021, 2:47 AM
★
★

Diff 906

View Options

core/kernel/db/cat_event_handler.php

Loading...
View Options

core/units/categories/categories_event_handler.php

Loading...
View Options

core/units/helpers/search_helper.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server