Page MenuHomeIn-Portal Phabricator
Differential D402

MINC-198 - Don't use "continue" inside a "switch" statement
ClosedPublic
Actions

Authored by alex on Mar 22 2021, 4:07 AM.

Details

Reviewers
erik
Commits
rMINC16695: Fixes MINC-198 - Don't use "continue" inside a "switch" statement
Test Plan
NOTE: perform tests on PHP 7.3+
  1. go to Installation Wizard at .../core/install.php URL
  2. confirm, that there is no warning shown on-screen about the continue statement

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1037
Build 1037: arc lint + arc unit

Event Timeline

alex created this revision.Mar 22 2021, 4:07 AM
alex requested review of this revision.Mar 22 2021, 4:07 AM
alex edited the test plan for this revision. (Show Details)Mar 24 2021, 5:21 AM
erik accepted this revision.Mar 24 2021, 5:26 AM
This revision is now accepted and ready to land.Mar 24 2021, 5:26 AM
Closed by commit rMINC16695: Fixes MINC-198 - Don't use "continue" inside a "switch" statement (authored by alex, committed by ). · Explain WhyJul 8 2022, 3:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1100916685Mar 22 2021, 4:07 AM
★
★
Diff 2104316693rMINC16695Jul 8 2022, 3:13 AM
★
★

Diff 1009

View Options

modules/in-commerce/units/taxes/taxes_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server