INP-1801 - Use dynamic protocol during installation
ClosedPublic
Actions

Authored by alex on Mar 23 2021, 4:21 AM.

Details

Reviewers

Commits

rINP16705: Fixes INP-1801 - Use dynamic protocol during installation

Test Plan

NOTE: All tests must be performed under an SSL connection (the "https://" URLs) with a valid SSL certificate (green lock)

delete /system/config.php file
go to Homepage (e.g. /)
confirm, that the "Go to installation script" link, that is shown, has the same protocol as the visited page
apply D403 patch
perform In-Portal installation with all the modules using SSL connection (https:// protocol)
confirm, that the SSL connection lock is not broken across the whole installation process

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not fixing issues, that existed prior to made changes

Severity	Location	Code	Message
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter	CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter	CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter	CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore	CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore	CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Error	core/install.php:162	PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore	CodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Error	core/install.php:166	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	core/install.php:168	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/install.php:168	PHPCS.E.PSR2.Methods.FunctionCallSignature.SpaceAfterOpenBracket	PSR2.Methods.FunctionCallSignature.SpaceAfterOpenBracket
Error	core/install.php:168	PHPCS.E.PSR2.Methods.FunctionCallSignature.SpaceBeforeCloseBracket	PSR2.Methods.FunctionCallSignature.SpaceBeforeCloseBracket
Warning	core/kernel/startup.php:33	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

No Unit Test Coverage

Build Status

Buildable 1039
Build 1039: arc lint + arc unit

Event Timeline

alex created this revision.Mar 23 2021, 4:21 AM

Herald added a reviewer: erik. · View Herald TranscriptMar 23 2021, 4:21 AM

alex requested review of this revision.Mar 23 2021, 4:21 AM

Harbormaster completed remote builds in B1039: Diff 1011.Mar 23 2021, 4:21 AM

alex edited the test plan for this revision. (Show Details)Mar 23 2021, 4:23 AM

alex added a parent revision: D403: MINC-199 - Escape MySQL 5.7 keywords in the "modules/in-commerce/install/install_schema.sql" file.

erik accepted this revision.Mar 30 2021, 5:26 AM

This revision is now accepted and ready to land.Mar 30 2021, 5:26 AM

This revision was landed with ongoing or failed builds.Jul 8 2022, 8:51 AM

Closed by commit rINP16705: Fixes INP-1801 - Use dynamic protocol during installation (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1011	16691		Mar 23 2021, 4:21 AM	★	★
Diff 2	1053	16704	rINP16705	Jul 8 2022, 8:51 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

	Status	Author	Revision
	Closed	alex	D404 INP-1801 - Use dynamic protocol during installation
	Closed	alex	D403 MINC-199 - Escape MySQL 5.7 keywords in the "modules/in-commerce/install/install_schema.sql" file

Diff 1011

View Options

core/install.php