INP-1802 - Speed up detection of countries with states
ClosedPublic
Actions

Authored by alex on Apr 22 2021, 8:38 AM.

Details

Reviewers

erik

Commits

Test Plan

login to Admin Console
go to E-commerce → Orders section
press Add toolbar button on the Incomplete tab
go to Shipping tab in the order adding window, that appeared
press on the Shipping tab again
confirm, that:
1. validaton error for missing Shipping State field happened
2. in the Debugger there is an SQL query for selecting countries with states (search for country_states_helper.php:63 text)
press on the Shipping tab again
confirm, that:
1. validaton error for missing Shipping State field happened
2. in the Debugger there isn't an SQL query for selecting countries with states (search for country_states_helper.php:63 text)
close order adding window by pressing Cancel
go to Configuration → Website → Countries & States section
try deleting record except United States or Canada
repeat above steps with Shipping tab to confirm, that SQL appears once again and then never is invoked

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

alex requested review of this revision.Apr 22 2021, 8:38 AM

alex added a project: Restricted Project.Apr 22 2021, 8:38 AM

erik accepted this revision.May 7 2021, 2:44 AM

This revision is now accepted and ready to land.May 7 2021, 2:44 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1012	16691		Apr 22 2021, 8:37 AM	★	★
Diff 2	1052	16703	rINP16704	Jul 8 2022, 8:37 AM	★	★