Page MenuHomeIn-Portal Phabricator

INP-1807 - Use dedicated connection for "kLogger" class
ClosedPublic

Authored by alex on Jun 18 2021, 9:14 AM.

Details

Test Plan

Plan

  1. run the UPDATE 52x_Modules` SET AppliedDBRevisions = '' WHERE Name = 'Custom';` to forget last executed deployment scripts
  2. change to modules/custom/install/project_upgrades.sql file to look like this:
# r1: Initial Project Task (#TASK_ID)
SELECT FirstName FROM `52x_Users`;
# some comment above error
ERROR1 ERROR2 ERROR3
SELECT LastName FROM `52x_Users`;
# some comment below error
  1. login to Admin Console
  2. go to ToolsSystem Tools section
  3. use the Deploy button
  4. confirm, that:
    • SQLs after ERROR1 ERROR2 ERROR3 line wasn't shown
    • error wasn't logged into Logs & ReportsSystem Log section
  5. get the value of the LogUniqueId field from any record of the 52x_SystemLog database table
  6. in the /index.php file add $application->deleteLog(LOG_UNIQUE_ID_HERE) after $application->Init(); line
  7. access changed /index.php file from web browser
  8. confirm, that log record was deleted

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing non-changed code
SeverityLocationCodeMessage
Errorcore/kernel/utility/logger.php:270PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingParamTagCodingStandard.Commenting.FunctionComment.MissingParamTag
Unit
No Unit Test Coverage
Build Status
Buildable 1046
Build 1046: arc lint + arc unit

Event Timeline

alex created this revision.Jun 18 2021, 9:14 AM
alex requested review of this revision.Jun 18 2021, 9:14 AM
alex edited the test plan for this revision. (Show Details)Jun 18 2021, 9:23 AM
erik accepted this revision.Jun 23 2021, 5:29 AM
This revision is now accepted and ready to land.Jun 23 2021, 5:29 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 8:20 AM
This revision was automatically updated to reflect the committed changes.