Differential D421

MINN-27 - Add missing export-related virtual fields
ClosedPublic
Actions

Authored by alex on Jul 20 2022, 2:42 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMINN16722: Fixes MINN-27 - Add missing export-related virtual fields

Test Plan

login into Admin Console
go to Structure & Data → News section
go to Articles tab
create an article (if there is none)
use Tools > Export menu
perform article export
confirm, that existing/just created article is present in the exported file
confirm, that export process hasn't caused any new System Log records to be created

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not fixing CS issues in this release.

Severity	Location	Code	Message
Error	modules/in-news/units/articles/articles_config.php:524	PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndChar	CodingStandard.Commenting.InlineComment.InvalidEndChar
Error	modules/in-news/units/articles/articles_config.php:524	PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapital	CodingStandard.Commenting.InlineComment.NotCapital
Error	modules/in-news/units/articles/articles_config.php:524	PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingAfter	CodingStandard.Commenting.InlineComment.SpacingAfter
Error	modules/in-news/units/articles/articles_config.php:526	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-news/units/articles/articles_config.php:526	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	modules/in-news/units/articles/articles_config.php:527	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-news/units/articles/articles_config.php:527	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	modules/in-news/units/articles/articles_config.php:528	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-news/units/articles/articles_config.php:528	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found

Unit

No Unit Test Coverage

Build Status

Buildable 1098
Build 1098: arc lint + arc unit

Event Timeline

alex created this revision.Jul 20 2022, 2:42 AM

Herald added a reviewer: erik. · View Herald TranscriptJul 20 2022, 2:42 AM

alex requested review of this revision.Jul 20 2022, 2:42 AM

Harbormaster completed remote builds in B1098: Diff 1068.Jul 20 2022, 2:42 AM

alex edited the test plan for this revision. (Show Details)Jul 20 2022, 2:45 AM

alex mentioned this in D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

alex added a child revision: D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

erik accepted this revision.Jul 20 2022, 5:22 AM

This revision is now accepted and ready to land.Jul 20 2022, 5:22 AM

This revision was landed with ongoing or failed builds.Jul 20 2022, 6:23 AM

Closed by commit rMINN16722: Fixes MINN-27 - Add missing export-related virtual fields (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1068

modules/in-news/units/articles/articles_config.php

Loading...