INP-1828 - Preserve engine type, when creating a temporary tables
ClosedPublic
Actions

Authored by alex on Sep 16 2022, 9:18 AM.

Details

Reviewers

erik

Commits

Test Plan

execute ALTER TABLE StopWords ENGINE = InnoDB; query in the project's database (add table prefix where needed)
confirm, that engine type of the StopWords table was changed to InnoDB, while other tables remained MyISAM
login to the Admin Console
go to Configuration → Website → Stop Words section
open any record for editing
confirm, that a temporary table was created for chosen record editing and it has InnoDB engine

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not fixing, what's not broken.

Severity	Location	Code	Message
Error	core/kernel/utility/temp_handler.php:188	PHPCS.E.CodingStandard.Commenting.FunctionComment.Missing	CodingStandard.Commenting.FunctionComment.Missing
Error	core/kernel/utility/temp_handler.php:188	PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.NotCamelCaps	CodingStandard.NamingConventions.ValidFunctionName.NotCamelCaps
Error	core/kernel/utility/temp_handler.php:188	PHPCS.E.Squiz.Scope.MethodScope.Missing	Squiz.Scope.MethodScope.Missing

Unit

No Unit Test Coverage

Build Status

Buildable 1135
Build 1135: arc lint + arc unit

alex requested review of this revision.Sep 16 2022, 9:18 AM

This revision is now accepted and ready to land.Sep 19 2022, 7:02 AM

This revision was landed with ongoing or failed builds.Nov 9 2022, 9:51 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1098	16722		Sep 16 2022, 9:18 AM	★	★
Diff 2	1122	16731	rINP16733	Sep 16 2022, 9:22 AM	★	★