Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • branches/5.2.x/core/admin_templates/js/forms.js
Differential D445

INP-1840 - Reset form scroll prior to window resizing handling
ClosedPublic
Actions

Authored by alex on Apr 11 2023, 9:02 AM.

Details

Reviewers
erik
Commits
rINP16773: Fixes INP-1840 - Reset form scroll prior to window resizing handling
Test Plan
  • in IDE:
    1. open the core/admin_templates/js/forms.js file for editing
    2. add console.log('resizing'); after Form.reizeTimeoutId = setTimeout(function () { line
    3. save changes
  • in Web Browser:
    1. login to the Admin Console
    2. go to the User Management → Groups section
    3. open any group for editing
    4. go to the Permissions tab
    5. open Web Browser inspector in a separate window (so that it won't reduce editing window height) on the Console tab and clear it's contents
    6. scroll to the end of the editing window
    7. confirm, that the Admin Skins section is visible
    8. scroll to the middle of the editing window
    9. increase the size of the editing window
    10. confirm, that a single resizing text was added to the Console tab of the Inspector window
    11. scroll to the end of the editing window
    12. confirm, that the Admin Skins section is visible

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Apr 11 2023, 9:02 AM
alex requested review of this revision.Apr 11 2023, 9:02 AM
alex added a project: Restricted Project.Apr 11 2023, 9:03 AM
erik accepted this revision.Apr 11 2023, 11:50 AM
This revision is now accepted and ready to land.Apr 11 2023, 11:50 AM
Closed by commit rINP16773: Fixes INP-1840 - Reset form scroll prior to window resizing handling (authored by alex, committed by ). · Explain WhyNov 22 2023, 2:45 AM
This revision was automatically updated to reflect the committed changes.
alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:34 AM
alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:51 AM
alex edited the test plan for this revision. (Show Details)Jan 16 2024, 6:53 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1114616753Apr 11 2023, 9:02 AM
★
★
Diff 2117316772rINP16773Nov 22 2023, 2:45 AM
★
★

Diff 1173

View Options

branches/5.2.x/core/admin_templates/js/forms.js

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server