INP-1847 - Specify image resizing defaults for category item images
AcceptedPublic
Actions

Authored by alex on Jan 2 2024, 4:13 AM.

Details

Reviewers

erik

Test Plan

in Admin Console
1. go to the Website & Content → Structure & Data → Products section
2. add some sub-categories (without images) to it
3. add some products (without images) to these categories
on the Front-End
1. open any of above created categories with products
2. confirm, that page contains no notices, except these:
  1. Usage of undefined configuration variable "c_ThumbnailImageWidth"...
  2. Declaration of SpamHelper::InitHelper() should be compatible with kHelper::InitHelper()...
3. confirm, that product image URL ends with /themes/advanced/platform/img/no_picture.gif
in IDE:
1. open themes/advanced/in-commerce/elements/products.elm.tpl file for editing
2. replace platform/img/no_picture.gif in the product_element block with platform/img/google_map_sample.gif
3. save changes
on the Front-End
1. reload the page with product list
2. confirm, that page contains no notices, except these:
  1. Usage of undefined configuration variable "c_ThumbnailImageWidth"...
  2. Declaration of SpamHelper::InitHelper() should be compatible with kHelper::InitHelper()...
3. confirm, that product image URL ends with /system/thumbs/themes/advanced/platform/img/google_map_sample_{N}.gif (there will be some number instead of {N})

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1224
Build 1224: arc lint + arc unit

alex requested review of this revision.Jan 2 2024, 4:13 AM

Test plan works well also without applying this patch.

This revision is now accepted and ready to land.Jan 2 2024, 5:02 AM

After in-portal update, test plan works well only after patch applying.

			Path	Packages
M			core/units/helpers/image_helper.php (3 lines)

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	alex	D373 INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used)
Accepted	alex	D453 INP-1847 - Specify image resizing defaults for category item images
Closed	erik	D368 INP-1668 - Allow specifying image quality, orientation and output format during resizing

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1180	16780		Jan 2 2024, 4:12 AM	★	★