Page MenuHomeIn-Portal Phabricator

INP-1531 Allow specifying default date/time for "inp_edit_date_time" control
ClosedPublic

Authored by erik on Mar 14 2016, 11:45 AM.

Details

Summary

Added new format and field option processing
in kDateFormatter::Format method.
Added new format usage in the inp_edit_date_time block in the adm.console.

Test Plan

Part 1 - regression testing

  1. go to ConfigurationWebsiteScheduled Tasks section
  2. click on "Add" button
  3. confirm that form opens and "Next Run On" field is empty
  4. click on date picker icon
  5. confirm that picker opens and contains current date and time
  6. pick some date
  7. confirm that picker closes and chosen date placed in the input field
  8. click on date picker icon
  9. confirm that picker opens and contains previously picked date and time
  10. save changes
  11. open added scheduled task for editing
  12. confirm, that previously entered date is displayed
  13. open date picker
  14. confirm, that entered previously date is displayed in date picker

Part 2 - new ability testing - repeat with relative value like 'midnight' and with exact time like '12/31/2015' as picker_default option value

  1. edit scheduled_tasks_config.php file - add 'picker_default' => 'midnight' option to the NextRunOn field configuration
  2. go to ConfigurationWebsiteScheduled Tasks section
  3. click on "Add" button
  4. confirm that form opens and "Next Run On" field is empty
  5. click on date picker icon
  6. confirm that picker opens and contains current date, but midnight time
  7. pick some date
  8. confirm that picker closes and chosen date placed in the input field
  9. click on date picker icon
  10. confirm that picker opens and contains previously picked date and time
  11. save changes
  12. open added scheduled task for editing
  13. confirm, that previously entered date is displayed
  14. open date picker
  15. confirm, that entered previously date is displayed in date picker

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: Change of method declaration is not part of this task.
SeverityLocationCodeMessage
Errorcore/kernel/utility/formatters/date_formatter.php:242PHPCS.E.CodingStandard.Commenting.FunctionComment.TypeHintMissingCodingStandard.Commenting.FunctionComment.TypeHintMissing
Unit
No Unit Test Coverage
Build Status
Buildable 337
Build 337: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 487.Mar 14 2016, 11:45 AM
erik retitled this revision from to INP-1531 Allow specifying default date/time for "inp_edit_date_time" control.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1531.
erik updated this revision to Diff 488.Mar 14 2016, 12:35 PM

Fixed difference with parent class in Format method declaration.

erik updated this revision to Diff 489.Mar 15 2016, 6:25 AM

Fixed for case when date entered in field with "picker" format.

alex accepted this revision.Mar 16 2016, 5:04 AM
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 5:05 AM
alex edited edge metadata.Mar 17 2016, 8:21 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.