Page MenuHomeIn-Portal Phabricator
Differential D230

INP-1567 - Register missing classes in class factory
ClosedPublic
Actions

Authored by alex on Jun 21 2016, 3:42 AM.

Details

Reviewers
erik
Commits
rINP16377: Fixes INP-1567 - Register missing classes in class factory
Test Plan

Preparations

  1. copy over /index.php into /autoloading_test.php
  2. in /autoloading_test.php file: replace all code that comes after $application->Init(); line with $object = new ClassNameHere();

Actual Test

Tested classes:

  • UnitConfigDecorator
  • kSubscriptionItem
  • clsCachedPermissions
  • clsRecursionStack
  • kXMLNode
  • kXMLNode5
  • XMLIterator
  • _BlockTag
  • _Tag_Comment
  • _Tag_DefineElement
  • _Tag_Capture
  • _Tag_RenderElement
  • _Tag_RenderElements
  • _Tag_Param
  • _Tag_Include
  • _Tag_If
  • _Tag_IfNot
  • _Tag_DefaultParam
  • _Tag_SetParam
  • _Tag_Cache
  • _Tag_IfDataExists
  • _Tag_Compress
  • kSubscriptionAnalyzer
  • UsersSyncronize

Change /autoloading_test.php and:

  • replace ClassNameHere with tested class
  • if that class needs constructor parameters put any that matches typehint
  • open /autoloading_test.php file from CLI or Web
  • confirm, that class instance was created and no error happened

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Unit configs were mass-fixed in 5.3.x.
SeverityLocationCodeMessage
Errorcore/kernel/nparser/nparser_config.php:23PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:24PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:25PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:26PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:27PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:28PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:29PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:30PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:31PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:32PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:33PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:34PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:35PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:36PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:37PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/kernel/nparser/nparser_config.php:38PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_config.php:23PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_config.php:23PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_config.php:24PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_config.php:24PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_config.php:27PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_config.php:27PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:24PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:24PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:25PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 402
Build 402: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 542.Jun 21 2016, 3:42 AM
alex retitled this revision from to INP-1567 - Register missing classes in class factory.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1567.
alex edited the test plan for this revision. (Show Details)Jun 21 2016, 3:48 AM
alex edited edge metadata.
erik accepted this revision.Jun 22 2016, 4:58 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 4:58 AM
Closed by commit rINP16377: Fixes INP-1567 - Register missing classes in class factory (authored by alex). · Explain WhyJul 25 2016, 3:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 154216347Jun 21 2016, 3:41 AM
★
★
Diff 258116376rINP16377Jul 25 2016, 3:45 AM
★
★

Diff 542

View Options

core/kernel/application.php

Loading...
View Options

core/kernel/nparser/nparser_config.php

Loading...
View Options

core/units/admin/admin_config.php

Loading...
View Options

core/units/categories/categories_config.php

Loading...
View Options

core/units/helpers/helpers_config.php

Loading...
View Options

core/units/system_event_subscriptions/system_event_subscriptions_config.php

Loading...
View Options

core/units/users/users_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server