Page MenuHomeIn-Portal Phabricator

INP-1641 - PHP 7 compatibility issues (5.2.x)
ClosedPublic

Authored by alex on Nov 19 2016, 6:25 AM.

Details

Test Plan
NOTE: All tests are to be performed on PHP 7. There are virtual machines with PHP 7 if you don't have it. The mod-rewrite must also be enabled.

Part 1

  1. in IDE:
    • open /system/debug.php file for editing
    • uncomment 'DBG_CACHE_URLS' => 0, line and save changes
  2. on Front-End
    • open hompeage (the / url)
    • confirm, that the homepage is actually displayed (not any other page)
    • confirm, that debugger doesn't contain any notices about $Array usage
    • click on Directory link top menu
    • confirm, that the Directory category is actually displayed (not any other page)
    • confirm, that debugger doesn't contain any notices about $Array usage

Part 2

  1. in IDE:
    • copy /index.php into /test.php
    • replace
$application->Run();
$application->Done();

with

$application->UnitConfigReader->iterateConfigs(
    function ($prefix, &$config_data, array $params) {
        echo $prefix . '<br/>' . PHP_EOL;
    },
    array()
);
  1. open /test.php in browser or CLI
  2. confirm, that prefixes from all registered unit configs are displayed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Won't be fixing, because code is replaced completely in 5.3.x.
SeverityLocationCodeMessage
Errorcore/kernel/managers/rewrite_url_processor.php:559PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/managers/rewrite_url_processor.php:559PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/kernel/utility/unit_config_reader.php:1036PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/kernel/utility/unit_config_reader.php:1036PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Unit
No Unit Test Coverage
Build Status
Buildable 541
Build 541: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 619.Nov 19 2016, 6:25 AM
alex retitled this revision from to INP-1641 - PHP 7 compatibility issues (5.2.x).
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1641.
alex edited reviewers, added: glebs; removed: erik.Nov 19 2016, 6:26 AM
glebs accepted this revision.Nov 24 2016, 10:29 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.