Page MenuHomeIn-Portal Phabricator
Feed All Stories

Aug 16 2024

alex added "INP-1725" JIRA issue(s) to rMINC16798: Bug INP-1725 - Introduce secure Session Key generation/storage.
Aug 16 2024, 3:27 AM
alex committed rMINC16798: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Aug 16 2024, 3:27 AM
alex added "INP-1725" JIRA issue(s) to rINP16797: Fixes INP-1725 - Introduce secure Session Key generation/storage.
Aug 16 2024, 3:27 AM
alex committed rINP16797: Fixes INP-1725 - Introduce secure Session Key generation/storage.
Fixes INP-1725 - Introduce secure Session Key generation/storage
Aug 16 2024, 3:27 AM
alex closed D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 16 2024, 3:27 AM · Restricted Project

Aug 14 2024

erik accepted D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 14 2024, 7:16 AM · Restricted Project

Aug 13 2024

alex updated the test plan for D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 13 2024, 3:34 AM · Restricted Project
alex added a comment to D479: INP-1725 - Introduce secure Session Key generation/storage.

@erik , you can safely accept without testing, because I've removed the code, that was causing the test to fail. Indeed code contained an error, but it's no longer needed.

Aug 13 2024, 3:33 AM · Restricted Project
alex updated the diff for D479: INP-1725 - Introduce secure Session Key generation/storage.
  1. removed Session Key: ... line in Debugger Report, because session key is already visible in the SQL query made before it
  2. [bugfix] new sid uniqueness checking during generation was made using SID itself and not it's hash
Aug 13 2024, 3:31 AM · Restricted Project

Aug 5 2024

erik accepted D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 9:38 AM · Restricted Project
erik requested changes to D480: INP-1872 - Properly handle constant absence during category cache rebuild.

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

Aug 5 2024, 9:12 AM · Restricted Project
alex added a project to D481: INP-1873 - Support MySQL 8 database collations: Restricted Project.
Aug 5 2024, 7:38 AM · Restricted Project
alex requested review of D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 7:38 AM · Restricted Project
erik added a comment to D479: INP-1725 - Introduce secure Session Key generation/storage.

All tests passed, excepting "confirm, that `Session Key: ..." line shows different value, than before (proves, that active sessions in the old format were upgraded and remain active)"

Aug 5 2024, 7:31 AM · Restricted Project
alex added a project to D480: INP-1872 - Properly handle constant absence during category cache rebuild: Restricted Project.
Aug 5 2024, 2:35 AM · Restricted Project
alex requested review of D480: INP-1872 - Properly handle constant absence during category cache rebuild.
Aug 5 2024, 2:35 AM · Restricted Project

Aug 2 2024

alex updated the test plan for D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 11:17 AM · Restricted Project
erik requested changes to D479: INP-1725 - Introduce secure Session Key generation/storage.

Test failed on Part 1 - Testing Upgrade (for In-Portal 5.2.x installation), in Web Browser open the /core/install.php URL

Aug 2 2024, 10:35 AM · Restricted Project
alex retitled D479: INP-1725 - Introduce secure Session Key generation/storage from Default to INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 6:09 AM · Restricted Project
alex updated the test plan for D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 6:07 AM · Restricted Project
alex updated the diff for D479: INP-1725 - Introduce secure Session Key generation/storage.

CS fixes

Aug 2 2024, 6:06 AM · Restricted Project
alex updated the diff for D479: INP-1725 - Introduce secure Session Key generation/storage.

Sent changes from the wrong changelist

Aug 2 2024, 5:51 AM · Restricted Project
alex added parent revisions for D479: INP-1725 - Introduce secure Session Key generation/storage: D476: INP-1870 - Save the session to the database immediately after the user login, D477: INP-1871 - Properly dispose session during logout workflow.
Aug 2 2024, 5:48 AM · Restricted Project
alex added a child revision for D477: INP-1871 - Properly dispose session during logout workflow: D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 5:48 AM
alex added a child revision for D476: INP-1870 - Save the session to the database immediately after the user login: D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 5:48 AM
alex updated the test plan for D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 5:47 AM · Restricted Project
alex requested review of D479: INP-1725 - Introduce secure Session Key generation/storage.
Aug 2 2024, 5:46 AM · Restricted Project

Aug 1 2024

alex added "INP-1756" JIRA issue(s) to rINP16796: [backported] Fixes INP-1756 - Create "Security*" classes for security-related….
Aug 1 2024, 3:04 AM
alex committed rINP16796: [backported] Fixes INP-1756 - Create "Security*" classes for security-related….
[backported] Fixes INP-1756 - Create "Security*" classes for security-related…
Aug 1 2024, 3:04 AM

Jul 31 2024

alex added "INP-1756" JIRA issue(s) to rINP16795: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:49 AM
alex committed rINP16795: Fixes INP-1756 - Create "Security*" classes for security-related jobs.
Fixes INP-1756 - Create "Security*" classes for security-related jobs
Jul 31 2024, 9:49 AM
alex closed D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:49 AM · Restricted Project
alex updated the test plan for D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 9:47 AM · Restricted Project
erik accepted D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 6:40 AM · Restricted Project
alex added a child revision for D354: INP-1756 - Create "Security*" classes for security-related jobs: D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:17 AM · Restricted Project
alex added a parent revision for D478: INP-1756 - Create "Security*" classes for security-related jobs: D354: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:17 AM · Restricted Project
alex added a project to D478: INP-1756 - Create "Security*" classes for security-related jobs: Restricted Project.
Jul 31 2024, 3:16 AM · Restricted Project
alex requested review of D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 3:12 AM · Restricted Project

Jul 29 2024

alex added "INP-1871" JIRA issue(s) to rINP16794: Fixes INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:57 AM
alex committed rINP16794: Fixes INP-1871 - Properly dispose session during logout workflow.
Fixes INP-1871 - Properly dispose session during logout workflow
Jul 29 2024, 9:57 AM
alex closed D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:57 AM
alex updated the test plan for D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 9:48 AM
erik accepted D477: INP-1871 - Properly dispose session during logout workflow.

Tested by using PHPStorm+XDebug with breakpoint in the SessionStorage::RemoveFromData method. Before patch applying SQL, that removes the priority_deleted session variable was executed. After patch applying SQL, that removes the priority_deleted session variable was not executed, because SessionSet property is set to false.

Jul 29 2024, 9:43 AM
alex updated the test plan for D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 8:24 AM
alex requested review of D477: INP-1871 - Properly dispose session during logout workflow.
Jul 29 2024, 8:24 AM
alex added "INP-1870" JIRA issue(s) to rINP16793: Fixes INP-1870 - Save the session to the database immediately after the user….
Jul 29 2024, 5:55 AM
alex committed rINP16793: Fixes INP-1870 - Save the session to the database immediately after the user….
Fixes INP-1870 - Save the session to the database immediately after the user…
Jul 29 2024, 5:55 AM
alex closed D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:55 AM
erik accepted D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:36 AM
alex updated the diff for D476: INP-1870 - Save the session to the database immediately after the user login.

Removed excessive session update statement, that happens after it's creation.

Jul 29 2024, 4:57 AM
alex updated the test plan for D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 4:54 AM
alex requested review of D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 4:50 AM