Unexpected output: Affected paths: relative - resubmit patch.
⚙ D542 INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Page MenuHomeIn-Portal Phabricator
Differential D542

INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
ClosedPublic
Actions

Authored by alex on Wed, Sep 3, 11:51 AM.

Details

Reviewers
erik
Commits
rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Test Plan
NOTE: Perform these tests after clean install and after upgrade.

Preparations

Apply the patch from the D539 if it's not already committed.

Test Plan

  1. login to the Admin Console
  2. go to the Configuration → Website → Advanced section
  3. enable the Track database changes to change log system setting and save changes
  4. re-login to the Admin Console
  5. go to the Logs & Reports → Session Log section
  6. confirm, that these extra columns are present and aren't empty:
    • Hostname
    • Server Hostname

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated
SeverityLocationCodeMessage
Errorcore/units/logs/session_logs/session_logs_config.php:124PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:124PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:125PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:125PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:126PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:126PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.AfterCodingStandard.WhiteSpace.CommaSpacing.After
Errorcore/units/logs/session_logs/session_logs_config.php:153PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:154PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:154PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/session_logs/session_logs_config.php:155PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/session_logs/session_logs_config.php:155PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Warningcore/units/logs/session_logs/session_logs_config.php:153PHPCS.W.CodingStandard.Arrays.Array.LastCommaCodingStandard.Arrays.Array.LastComma
Unit
No Unit Test Coverage
Build Status
Buildable 11155
Build 3855: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Sep 3, 11:51 AM
alex requested review of this revision.Wed, Sep 3, 11:51 AM
erik requested changes to this revision.Wed, Sep 3, 12:25 PM

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

This revision now requires changes to proceed.Wed, Sep 3, 12:25 PM
alex edited the test plan for this revision. (Show Details)Thu, Sep 4, 2:18 AM
alex requested review of this revision.Thu, Sep 4, 2:24 AM
In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

The missing phrase was added as part of D539. Since it's committed already, then you:

  • either started testing before I've made a commit (before Wed, Sep 3, 19:46)
  • or haven't updated a project before starting the testing

Either way please update the project now and repeat the test.

erik requested changes to this revision.Thu, Sep 4, 5:11 AM

In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.

This revision now requires changes to proceed.Thu, Sep 4, 5:11 AM
alex updated this revision to Diff 1405.Thu, Sep 4, 5:57 AM

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

erik accepted this revision.Thu, Sep 4, 6:28 AM
This revision is now accepted and ready to land.Thu, Sep 4, 6:28 AM
This revision was landed with ongoing or failed builds.Thu, Sep 4, 7:28 AM
Closed by commit rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1140416859Wed, Sep 3, 11:51 AM
★
★
Diff 2140516859Use "la_fld_LogServerHostname" phrases (existing) instead of…Thu, Sep 4, 5:57 AM
★
★
Diff 3140616859rINP16860Thu, Sep 4, 7:28 AM
★
★

Diff 1405

View Options

core/install/install_schema.sql

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

core/units/logs/session_logs/session_log_eh.php

Loading...
View Options

core/units/logs/session_logs/session_logs_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server