Differential D207

INP-1543 - Return detected theme/language ID immediately from "getPassedID" method
ClosedPublic
Actions

Authored by alex on Mar 19 2016, 4:13 AM.

Details

Reviewers

glebs

Commits

rINP16353: Fixes INP-1543 - Return detected theme/language ID immediately from…

Test Plan

login to Admin Console
go to Configuration → Website → Advanced section
uncheck Enable SEO-friendly URLs mode (MOD-REWRITE) checkbox and save changes
go to Configuration → Website → Regional section
ensure that at least 2 enabled languages are present and English language is set as primary
go to Configuration → Website → Themes section
ensure, that advanced and default themes are enabled and advanced theme is set as primary
go to Front-End by removing /admin/.... part from url (important not to have index.php in resulting url)
confirm, that English language and advanced theme were used
click on Home icon in top menu
confirm, that URL ends up with ?env=-index:m0-1-X-Y-s- where:
- X matches ID of English language
- Y matches ID of advanced theme
change X in above URL to match ID of any other enabled language
confirm, that specified language was used instead of primary one
change Y in above URL to match ID of any other enabled theme
confirm, that specified theme was used instead of primary one

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 348
Build 348: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 500.Mar 19 2016, 4:13 AM

alex retitled this revision from to INP-1543 - Return detected theme/language ID immediately from "getPassedID" method..

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1543.

Herald added a reviewer: glebs. · View Herald TranscriptMar 19 2016, 4:13 AM

alex retitled this revision from INP-1543 - Return detected theme/language ID immediately from "getPassedID" method. to INP-1543 - Return detected theme/language ID immediately from "getPassedID" method.Mar 19 2016, 4:13 AM

alex edited edge metadata.

alex added a child revision: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

alex added a parent revision: D16: INP-1387 - Move primary theme/language detection into corresponding units.Mar 24 2016, 4:13 AM

glebs accepted this revision.Apr 19 2016, 2:07 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2016, 2:07 AM

Closed by commit rINP16353: Fixes INP-1543 - Return detected theme/language ID immediately from… (authored by alex). · Explain WhyJul 10 2016, 3:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	500	16318		Mar 19 2016, 4:13 AM	★	★
Diff 2	554	16352	rINP16353	Jul 10 2016, 3:00 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	alex	D68 INP-1422 - Store class map on disk
Closed	alex	D62 INP-1424 Don't call "refreshModuleInfo" twice in a row
Closed	alex	D64 INP-1426 Speed up admin tree cache building
Closed	alex	D17 INP-1388 - Make CKEditor stylesheet within theme editable
Changes Planned	alex	D180 INP-1516 - Do not use "Web Request" and "Session" concepts in CLI
Closed	alex	D50 INP-1413 - Don't do full Application Init during deployment
Closed	alex	D174 INP-1520 - Honor manually set owner of categories/category items created from CLI
Closed	alex	D175 INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
Closed	alex	D179 INP-1523 - Populate user info, when sending membership expiration e-mails
Closed	alex	D176 MINL-18 - Change link categories automatically according to it's Listing Type
Closed	alex	D173 MINN-11 - Specify category for RSS feed articles via "CategoryId" field
Closed	alex	D169 INP-1517 - Define INDEX_FILE constant in each CLI script
Closed	alex	D170 INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method
Closed	alex	D172 MINN-10 - Don't use Web Request during Article adding/editing
Closed	alex	D207 INP-1543 - Return detected theme/language ID immediately from "getPassedID" method
Closed	alex	D16 INP-1387 - Move primary theme/language detection into corresponding units
Closed	alex	D208 INP-1544 - Delete expired session without using "Session" object
Closed	alex	D212 MINB-26 - Don't persist data for anonymous users
Closed	alex	D282 INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method

Diff 500

View Options

core/units/languages/languages_event_handler.php