Grammar fix.

Add code comment, that describes why high precision formats are not supported.

The test plan is incomplete. Test plan should be written for someone, who doesn't understand what they are testing.

Keep up the good work.

False alarm. Turned out to be an issue within customized code on one of the projects.

I'm getting No Permission error today (not sure why I wasn't getting it when this was developed initially). Need to investigate.

Please revert change, that makes red categories not present in sitemap by default (seems to be 2 places: sql during upgrade and $in_sitemap = false during auto-creation), because it creates nasty side effect: when debug mode is enabled I don't see Platform category (IncludeInSitemap=0), while it's sub-categories (e.g. Maintenance Mode) are marked as IncludeInSitemap.

I see following warnings when full Advanced theme rescan is happening:

• simplexml_load_string(): Entity: line 1: parser error : xmlParseEntityRef: no name
• simplexml_load_string(): <meta_info>CSS & JAVASCRIPT FOR IN-COMMERCE</meta_info>
• simplexml_load_string(): ^

Rollback changes, that were added through applying another needed patch.

Forgot to add language pack changes

The test plan wasn't changed as requested.

... added Clear() calls to fit new plan.

Just send revision for review somehow without making any code changes.

The test plan:

• doesn't include steps for testing clean install/upgrade
• doesn't work (I've tried to do as written in test plan and problem is still there)

Code tested according to plan. Please do that last cosmetical change and we're done here.

Please thoroughly look through each comment I leave (every time on every revision). If you decide not to do as I've advised, then please explain why as a reply to relevant comment.

10. add temporary line "$event->status = kEvent::erFAIL;" to CategoriesEventHandler::OnBeforeItemUpdate
11. confirm that Approve and Decline buttons do not change Status for categories, but also no fatal error happens
12. remove temporary line "$event->status = kEvent::erFAIL;" from CategoriesEventHandler::OnBeforeItemUpdate

The test plan seems to out of sync with reality this time as well.

Aside from inline comments following needs to be fixed in the test plan as well:

Please re-test.

Selecting Structure & Data category wasn't causing tab auto-switching.

The Sections tab isn't activated when topmost section (the Structure & Data) is clicked.

Also test plan doesn't cover code path, that caused search table removal in past (e.g. make search that finds something and then make search with short/empty keyword).

1. test plan is missing tests, that demonstrate, that problem, described in Confluence, no longer happen under same conditions
2. please remove ShippingQuoteEngineEventHandler::iterateItems method because the only thing it does it rolling back event status change, that no longer happens in parent class method

Links placed in Home category weren't shown on Front-End even with all permissions given.