Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.
- Queries
- All Stories
- Search
- Advanced Search
Feed All Stories
All Stories
All Stories
Sep 4 2025
Sep 4 2025
alex updated the diff for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
In D542#11101, @erik wrote:All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).
alex updated the test plan for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Sep 3 2025
Sep 3 2025
erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Fixes INP-1923 - Display "Server Hostname" in the System Log
alex added "INP-1923" JIRA issue(s) to rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Extracted Arcanist integration into a separate Differential Revision.
alex added "INP-1924" JIRA issue(s) to rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
alex committed rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet…
alex committed rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"…
alex added "INP-1900" JIRA issue(s) to rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
alex updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Rename test file/class to make Phabricator understand PHPUnit test results/coverage.
Fixes INP-1925 - Configure PHPUnit integration with Arcanist
alex added "INP-1925" JIRA issue(s) to rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Replaced assertEquels with assertSame in all tests, added in this revision.
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Sep 2 2025
Sep 2 2025
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Added test case when pounds and ounces both are zero.
erik added inline comments to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Made all requested fixes. Created tests for kUbitFormatter class.
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Also try to modify tested code to confirm, that related tests would fail.
Sep 1 2025
Sep 1 2025
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Changed ligic, added unit tests.
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):
Aug 31 2025
Aug 31 2025
alex added "INP-1874" JIRA issue(s) to rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value
alex added "INP-1876" JIRA issue(s) to rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
alex committed rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Fixes INP-1876 - Verify system settings access permissions before allowing to…
alex closed D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Aug 31 2025, 12:15 PM · Restricted Project
alex added "INP-1880" JIRA issue(s) to rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Fixes INP-1880 - Fix notice on missing event permission mapping
Aug 31 2025, 12:09 PM · Restricted Project
alex added "INP-1887" JIRA issue(s) to rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
alex committed rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation…
alex added "INP-1888" JIRA issue(s) to rINP16851: Fixes INP-1888 - Detect Memcache availability during installation using….
Fixes INP-1888 - Detect Memcache availability during installation using…
Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing
alex added "INP-1889" JIRA issue(s) to rINP16850: Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
alex added "INP-1891" JIRA issue(s) to rINP16849: Fixes INP-1891 - Display PHP errors in the Phing build log.
Fixes INP-1891 - Display PHP errors in the Phing build log
alex added "INP-1894" JIRA issue(s) to rINP16848: Bug INP-1894 - Extract "Change Log" code to a central place.
Bug INP-1894 - Extract "Change Log" code to a central place
alex added "INP-1905" JIRA issue(s) to rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
alex committed rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from…
alex added "INP-1908" JIRA issue(s) to rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
alex committed rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
Fixes INP-1908 - Discard template parser opened output buffers before doing a…
alex added "INP-1910" JIRA issue(s) to rINP16845: Fixes INP-1910 - Allow specifying upcoming System Log record defaults.
Fixes INP-1910 - Allow specifying upcoming System Log record defaults
alex added "MINC-210" JIRA issue(s) to rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
alex committed rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End
alex added "INP-1853" JIRA issue(s) to rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
alex committed rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log…
alex added "INP-1852" JIRA issue(s) to rINP16842: Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method.
Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method
Aug 31 2025, 11:30 AM · Restricted Project
alex added "INP-1854" JIRA issue(s) to rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
alex committed rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
Fixes INP-1854 - Create global switch for Web Request/Session Data logging into…
Aug 14 2025
Aug 14 2025
Aug 14 2025, 1:36 PM · Restricted Project
Aug 14 2025, 5:36 AM · Restricted Project
Aug 14 2025, 5:36 AM · Restricted Project
Fixed the filesize(): stat failed for error when uploading file larger, than 1MB.
Aug 14 2025, 5:26 AM · Restricted Project
Aug 13 2025
Aug 13 2025
Aug 11 2025
Aug 11 2025
In D529#10934, @erik wrote:Added tests for Core and Custom modules -
unknown_option_tests_v2.patch72 KBDownload