Page MenuHomeIn-Portal Phabricator

INP-1751 - Use PHP5-style constructor names only in LibChart library code

Authored by alex on Oct 29 2018, 8:32 AM.


Test Plan
NOTE: Perform tests on PHP 7.0+ with System Log enabled and In-Commerce module installed.
  1. login to Admin Console
  2. go to E-commerceSales Report section
  3. click on Run Report toolbar button to submit a form
  4. click on View Chart toolbar button to generate a chart in new window
  5. confirm, that no PHP errors/warnings/notices are happening, where errored file is from core/units/general/libchart folder

Diff Detail

rINP In-Portal
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Oct 29 2018, 8:32 AM
alex added a project: Restricted Project.Oct 30 2018, 11:05 AM
erik accepted this revision.Oct 31 2018, 6:17 AM
This revision is now accepted and ready to land.Oct 31 2018, 6:17 AM
This revision was landed with ongoing or failed builds.Jan 11 2021, 3:01 AM
This revision was automatically updated to reflect the committed changes.