Page MenuHomeIn-Portal Phabricator
Differential D350

INP-1751 - Use PHP5-style constructor names only in LibChart library code
ClosedPublic
Actions

Authored by alex on Oct 29 2018, 8:32 AM.

Details

Reviewers
erik
Commits
rINP16666: Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code
Test Plan
NOTE: Perform tests on PHP 7.0+ with System Log enabled and In-Commerce module installed.
  1. login to Admin Console
  2. go to E-commerce → Sales Report section
  3. click on Run Report toolbar button to submit a form
  4. click on View Chart toolbar button to generate a chart in new window
  5. confirm, that no PHP errors/warnings/notices are happening, where errored file is from core/units/general/libchart folder

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: CS fixes of vendor code isn't responsibility of In-Portal.
SeverityLocationCodeMessage
Errorcore/units/general/libchart/classes/model/Point.php:38PHPCS.E.CodingStandard.Commenting.FunctionComment.TypeHintMissingCodingStandard.Commenting.FunctionComment.TypeHintMissing
Errorcore/units/general/libchart/classes/model/Point.php:38PHPCS.E.CodingStandard.Commenting.FunctionComment.TypeHintMissingCodingStandard.Commenting.FunctionComment.TypeHintMissing
Errorcore/units/general/libchart/classes/model/Point.php:38PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/model/Point.php:38PHPCS.E.PEAR.Functions.FunctionDeclaration.BraceOnSameLinePEAR.Functions.FunctionDeclaration.BraceOnSameLine
Errorcore/units/general/libchart/classes/model/Point.php:60PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errorcore/units/general/libchart/classes/model/Point.php:60PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/model/XYDataSet.php:34PHPCS.E.CodingStandard.Commenting.DocComment.SpacingAfterCodingStandard.Commenting.DocComment.SpacingAfter
Errorcore/units/general/libchart/classes/model/XYDataSet.php:35PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/model/XYDataSet.php:35PHPCS.E.PEAR.Functions.FunctionDeclaration.BraceOnSameLinePEAR.Functions.FunctionDeclaration.BraceOnSameLine
Errorcore/units/general/libchart/classes/model/XYDataSet.php:57PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errorcore/units/general/libchart/classes/model/XYDataSet.php:57PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/model/XYSeriesDataSet.php:43PHPCS.E.CodingStandard.Commenting.DocComment.SpacingAfterCodingStandard.Commenting.DocComment.SpacingAfter
Errorcore/units/general/libchart/classes/model/XYSeriesDataSet.php:44PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/model/XYSeriesDataSet.php:44PHPCS.E.PEAR.Functions.FunctionDeclaration.BraceOnSameLinePEAR.Functions.FunctionDeclaration.BraceOnSameLine
Errorcore/units/general/libchart/classes/model/XYSeriesDataSet.php:77PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errorcore/units/general/libchart/classes/model/XYSeriesDataSet.php:77PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/view/axis/Axis.php:43PHPCS.E.CodingStandard.Commenting.FunctionComment.TypeHintMissingCodingStandard.Commenting.FunctionComment.TypeHintMissing
Errorcore/units/general/libchart/classes/view/axis/Axis.php:43PHPCS.E.CodingStandard.Commenting.FunctionComment.TypeHintMissingCodingStandard.Commenting.FunctionComment.TypeHintMissing
Errorcore/units/general/libchart/classes/view/axis/Axis.php:43PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/view/axis/Axis.php:43PHPCS.E.PEAR.Functions.FunctionDeclaration.BraceOnSameLinePEAR.Functions.FunctionDeclaration.BraceOnSameLine
Errorcore/units/general/libchart/classes/view/axis/Axis.php:131PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errorcore/units/general/libchart/classes/view/axis/Axis.php:131PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/view/caption/Caption.php:44PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/general/libchart/classes/view/caption/Caption.php:44PHPCS.E.PEAR.Functions.FunctionDeclaration.BraceOnSameLinePEAR.Functions.FunctionDeclaration.BraceOnSameLine
Errorcore/units/general/libchart/classes/view/caption/Caption.php:113PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 894
Build 894: arc lint + arc unit

Event Timeline

alex created this revision.Oct 29 2018, 8:32 AM
alex added a project: Restricted Project.Oct 30 2018, 11:05 AM
erik accepted this revision.Oct 31 2018, 6:17 AM
This revision is now accepted and ready to land.Oct 31 2018, 6:17 AM
This revision was landed with ongoing or failed builds.Jan 11 2021, 3:01 AM
Closed by commit rINP16666: Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 187416632Oct 29 2018, 8:32 AM
★
★
Diff 297616665rINP16666Jan 11 2021, 3:01 AM
★
★

Diff 874

View Options

core/units/general/libchart/classes/model/Point.php

Loading...
View Options

core/units/general/libchart/classes/model/XYDataSet.php

Loading...
View Options

core/units/general/libchart/classes/model/XYSeriesDataSet.php

Loading...
View Options

core/units/general/libchart/classes/view/axis/Axis.php

Loading...
View Options

core/units/general/libchart/classes/view/caption/Caption.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/BarChart.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/Chart.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/HorizontalBarChart.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/LineChart.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/PieChart.php

Loading...
View Options

core/units/general/libchart/classes/view/chart/VerticalBarChart.php

Loading...
View Options

core/units/general/libchart/classes/view/color/Color.php

Loading...
View Options

core/units/general/libchart/classes/view/color/ColorSet.php

Loading...
View Options

core/units/general/libchart/classes/view/color/Palette.php

Loading...
View Options

core/units/general/libchart/classes/view/plot/Plot.php

Loading...
View Options

core/units/general/libchart/classes/view/primitive/Padding.php

Loading...
View Options

core/units/general/libchart/classes/view/primitive/Primitive.php

Loading...
View Options

core/units/general/libchart/classes/view/primitive/Rectangle.php

Loading...
View Options

core/units/general/libchart/classes/view/text/Text.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server